Changeset 85570 in vbox

Timestamp:

Jul 30, 2020 8:26:54 PM (4 years ago)

Author:

vboxsync

Message:

DrvHostPulseAudio.cpp: put the mainloop creatation outside the silly while-not-a-goto loop. bugref:8666

File:

• trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp

@@ -676 +676 @@
 
     pThis->fAbortLoop = false;
-    pThis->pMainLoop = NULL;
+    pThis->pMainLoop = pa_threaded_mainloop_new();
+    if (!pThis->pMainLoop)
+    {
+        LogRel(("PulseAudio: Failed to allocate main loop: %s\n", pa_strerror(pa_context_errno(pThis->pContext))));
+        return VERR_NO_MEMORY;
+    }
 
     bool fLocked = false;
@@ -682 +687 @@
     do
     {
-        if (!(pThis->pMainLoop = pa_threaded_mainloop_new()))
-        {
-            LogRel(("PulseAudio: Failed to allocate main loop: %s\n",
-                     pa_strerror(pa_context_errno(pThis->pContext))));
-            rc = VERR_NO_MEMORY;
-            break;
-        }
-
         if (!(pThis->pContext = pa_context_new(pa_threaded_mainloop_get_api(pThis->pMainLoop), "VirtualBox")))
         {