Changeset 85634 in vbox for trunk/src/VBox/Frontends

Timestamp:

Aug 6, 2020 10:37:12 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

139744

Message:

FE/Qt: bugref:9609: A bit of cleanup for action-pool stuff: Move virtual state handler for UIAction class to separate method, previously was absent and inherited classes had to use retranslateUi for that.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/globals

Files:

• UIActionPool.cpp (modified) (1 diff)
• UIActionPool.h (modified) (2 diffs)
• UIActionPoolManager.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIActionPool.cpp

@@ -130 +130 @@
     updateIcon();
     retranslateUi();
+    handleStateChange();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIActionPool.h

@@ -54 +54 @@
     UIActionType_Simple,
     UIActionType_Toggle,
-    UIActionType_Polymorphic,
     UIActionType_PolymorphicMenu
 };
@@ -267 +266 @@
     UIAction(UIActionPool *pParent, UIActionType enmType, bool fMachineMenuAction = false);
 
+    /** Handles state change. */
+    virtual void handleStateChange() {}
+
     /** Returns current action name in menu. */
     QString nameInMenu() const;

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIActionPoolManager.cpp

@@ -951 +951 @@
             case 0:
             {
-                showMenu();
                 setName(QApplication::translate("UIActionPool", "S&tart"));
                 setStatusTip(QApplication::translate("UIActionPool", "Start selected virtual machines"));
@@ -959 +958 @@
             case 1:
             {
-                hideMenu();
                 setName(QApplication::translate("UIActionPool", "S&how"));
                 setStatusTip(QApplication::translate("UIActionPool", "Switch to the windows of selected virtual machines"));
@@ -967 +965 @@
             default:
                 break;
+        }
+    }
+
+    /** Handles state change. */
+    virtual void handleStateChange() /* override */
+    {
+        switch (state())
+        {
+            case 0: showMenu(); break;
+            case 1: hideMenu(); break;
+            default: break;
         }
     }