Changeset 85645 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Aug 7, 2020 6:04:37 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9812. Removing UIMachineSettingsSFDetails.ui

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• VBoxUI.pro (modified) (1 diff)
• src/settings/machine/UIMachineSettingsSF.cpp (modified) (2 diffs)
• src/settings/machine/UIMachineSettingsSFDetails.cpp (modified) (7 diffs)
• src/settings/machine/UIMachineSettingsSFDetails.h (modified) (2 diffs)
• src/settings/machine/UIMachineSettingsSFDetails.ui (deleted)

trunk/src/VBox/Frontends/VirtualBox/VBoxUI.pro

@@ -41 +41 @@
     src/settings/machine/UIMachineSettingsUSB.ui \
     src/settings/machine/UIMachineSettingsUSBFilterDetails.ui \
-    src/settings/machine/UIMachineSettingsSFDetails.ui \
     src/settings/machine/UIMachineSettingsInterface.ui
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSF.cpp

@@ -20 +20 @@
 #include <QMenu>
 #include <QTimer>
+#include <QVBoxLayout>
 
 /* GUI includes: */
@@ -693 +694 @@
     if (objectName().isEmpty())
         setObjectName(QStringLiteral("UIMachineSettingsSF"));
-    resize(300, 228);
+    resize(300, 220);
     QVBoxLayout *pMainLayout = new QVBoxLayout(this);
     pMainLayout->setObjectName(QStringLiteral("pMainLayout"));

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSFDetails.cpp

@@ -17 +17 @@
 
 /* Qt includes */
+#include <QCheckBox>
 #include <QDir>
+#include <QGridLayout>
+#include <QLabel>
+#include <QLineEdit>
 #include <QPushButton>
 
-/* Other includes */
+/* GUI includes */
+#include "QIDialogButtonBox.h"
+#include "UIFilePathSelector.h"
 #include "UIMachineSettingsSFDetails.h"
 #include "UICommon.h"
@@ -29 +35 @@
                                                        const QStringList &usedNames,
                                                        QWidget *pParent /* = 0 */)
-   : QIWithRetranslateUI2<QIDialog>(pParent)
-   , m_type(type)
-   , m_fUsePermanent(fEnableSelector)
-   , m_usedNames(usedNames)
-{
-    /* Apply UI decorations: */
-    Ui::UIMachineSettingsSFDetails::setupUi(this);
+    : QIWithRetranslateUI2<QIDialog>(pParent)
+    , m_type(type)
+    , m_fUsePermanent(fEnableSelector)
+    , m_usedNames(usedNames)
+    , m_pPathSelector(0)
+    , m_pPermanentCheckBox(0)
+    , m_pNameLineEdit(0)
+    , m_pReadonlyCheckBox(0)
+    , m_pAutoMountCheckBox(0)
+    , m_pAutoMountPointLineEdit(0)
+    , m_pPathLabel(0)
+    , m_pNameLabel(0)
+    , m_pAutoMountPointLabel(0)
+    , m_pButtonBox(0)
+{
+    prepareWidgets();
 
     /* Setup widgets: */
-    mPsPath->setResetEnabled(false);
-    mPsPath->setHomeDir(QDir::homePath());
-    mCbPermanent->setHidden(!fEnableSelector);
+    m_pPathSelector->setResetEnabled(false);
+    m_pPathSelector->setHomeDir(QDir::homePath());
+    m_pPermanentCheckBox->setHidden(!fEnableSelector);
 
     /* Setup connections: */
-    connect(mPsPath, static_cast<void(UIFilePathSelector::*)(int)>(&UIFilePathSelector::currentIndexChanged),
+    connect(m_pPathSelector, static_cast<void(UIFilePathSelector::*)(int)>(&UIFilePathSelector::currentIndexChanged),
             this, &UIMachineSettingsSFDetails::sltSelectPath);
-    connect(mPsPath, &UIFilePathSelector::pathChanged, this, &UIMachineSettingsSFDetails::sltSelectPath);
-    connect(mLeName, &QLineEdit::textChanged, this, &UIMachineSettingsSFDetails::sltValidate);
+    connect(m_pPathSelector, &UIFilePathSelector::pathChanged, this, &UIMachineSettingsSFDetails::sltSelectPath);
+    connect(m_pNameLineEdit, &QLineEdit::textChanged, this, &UIMachineSettingsSFDetails::sltValidate);
     if (fEnableSelector)
-        connect(mCbPermanent, &QCheckBox::toggled, this, &UIMachineSettingsSFDetails::sltValidate);
+        connect(m_pPermanentCheckBox, &QCheckBox::toggled, this, &UIMachineSettingsSFDetails::sltValidate);
 
      /* Applying language settings: */
@@ -65 +80 @@
 }
 
+void UIMachineSettingsSFDetails::prepareWidgets()
+{
+    if (objectName().isEmpty())
+        setObjectName(QStringLiteral("UIMachineSettingsSFDetails"));
+    resize(218, 196);
+    QGridLayout *gridLayout = new QGridLayout(this);
+    gridLayout->setObjectName(QStringLiteral("gridLayout"));
+    m_pPathLabel = new QLabel;
+    m_pPathLabel->setObjectName(QStringLiteral("m_pPathLabel"));
+    m_pPathLabel->setAlignment(Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter);
+
+    gridLayout->addWidget(m_pPathLabel, 0, 0, 1, 1);
+
+    m_pPathSelector = new UIFilePathSelector;
+    m_pPathSelector->setObjectName(QStringLiteral("m_pPathSelector"));
+    gridLayout->addWidget(m_pPathSelector, 0, 1, 1, 1);
+
+    m_pNameLabel = new QLabel;
+    m_pNameLabel->setObjectName(QStringLiteral("m_pNameLabel"));
+    m_pNameLabel->setAlignment(Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter);
+    gridLayout->addWidget(m_pNameLabel, 1, 0, 1, 1);
+
+    m_pNameLineEdit = new QLineEdit;
+    m_pNameLineEdit->setObjectName(QStringLiteral("m_pNameLineEdit"));
+    gridLayout->addWidget(m_pNameLineEdit, 1, 1, 1, 1);
+
+    m_pReadonlyCheckBox = new QCheckBox;
+    m_pReadonlyCheckBox->setObjectName(QStringLiteral("m_pReadonlyCheckBox"));
+    gridLayout->addWidget(m_pReadonlyCheckBox, 2, 1, 1, 1);
+
+    m_pAutoMountCheckBox = new QCheckBox;
+    m_pAutoMountCheckBox->setObjectName(QStringLiteral("m_pAutoMountCheckBox"));
+    gridLayout->addWidget(m_pAutoMountCheckBox, 3, 1, 1, 1);
+
+    m_pAutoMountPointLabel = new QLabel;
+    m_pAutoMountPointLabel->setObjectName(QStringLiteral("m_pAutoMountPointLabel"));
+    m_pAutoMountPointLabel->setAlignment(Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter);
+    gridLayout->addWidget(m_pAutoMountPointLabel, 4, 0, 1, 1);
+
+    m_pAutoMountPointLineEdit = new QLineEdit;
+    m_pAutoMountPointLineEdit->setObjectName(QStringLiteral("m_pAutoMountPointLineEdit"));
+    gridLayout->addWidget(m_pAutoMountPointLineEdit, 4, 1, 1, 1);
+
+    m_pPermanentCheckBox = new QCheckBox;
+    m_pPermanentCheckBox->setObjectName(QStringLiteral("m_pPermanentCheckBox"));
+    gridLayout->addWidget(m_pPermanentCheckBox, 5, 1, 1, 1);
+
+    QSpacerItem *spacerItem = new QSpacerItem(20, 40, QSizePolicy::Minimum, QSizePolicy::Expanding);
+    gridLayout->addItem(spacerItem, 6, 1, 1, 1);
+
+    m_pButtonBox = new QIDialogButtonBox;
+    m_pButtonBox->setObjectName(QStringLiteral("m_pButtonBox"));
+    m_pButtonBox->setStandardButtons(QDialogButtonBox::Cancel|QDialogButtonBox::NoButton|QDialogButtonBox::Ok);
+    gridLayout->addWidget(m_pButtonBox, 7, 0, 1, 2);
+
+
+    QObject::connect(m_pButtonBox, &QIDialogButtonBox::accepted, this, &UIMachineSettingsSFDetails::accept);
+    QObject::connect(m_pButtonBox, &QIDialogButtonBox::rejected, this, &UIMachineSettingsSFDetails::reject);
+}
+
+
 void UIMachineSettingsSFDetails::setPath(const QString &strPath)
 {
-    mPsPath->setPath(strPath);
+    m_pPathSelector->setPath(strPath);
 }
 
 QString UIMachineSettingsSFDetails::path() const
 {
-    return mPsPath->path();
+    return m_pPathSelector->path();
 }
 
 void UIMachineSettingsSFDetails::setName(const QString &strName)
 {
-    mLeName->setText(strName);
+    m_pNameLineEdit->setText(strName);
 }
 
 QString UIMachineSettingsSFDetails::name() const
 {
-    return mLeName->text();
+    return m_pNameLineEdit->text();
 }
 
 void UIMachineSettingsSFDetails::setWriteable(bool fWritable)
 {
-    mCbReadonly->setChecked(!fWritable);
+    m_pReadonlyCheckBox->setChecked(!fWritable);
 }
 
 bool UIMachineSettingsSFDetails::isWriteable() const
 {
-    return !mCbReadonly->isChecked();
+    return !m_pReadonlyCheckBox->isChecked();
 }
 
 void UIMachineSettingsSFDetails::setAutoMount(bool fAutoMount)
 {
-    mCbAutoMount->setChecked(fAutoMount);
+    m_pAutoMountCheckBox->setChecked(fAutoMount);
 }
 
 bool UIMachineSettingsSFDetails::isAutoMounted() const
 {
-    return mCbAutoMount->isChecked();
+    return m_pAutoMountCheckBox->isChecked();
 }
 
 void UIMachineSettingsSFDetails::setAutoMountPoint(const QString &strAutoMountPoint)
 {
-    mLeAutoMountPoint->setText(strAutoMountPoint);
+    m_pAutoMountPointLineEdit->setText(strAutoMountPoint);
 }
 
 QString UIMachineSettingsSFDetails::autoMountPoint() const
 {
-    return mLeAutoMountPoint->text();
+    return m_pAutoMountPointLineEdit->text();
 }
 
 void UIMachineSettingsSFDetails::setPermanent(bool fPermanent)
 {
-    mCbPermanent->setChecked(fPermanent);
+    m_pPermanentCheckBox->setChecked(fPermanent);
 }
 
 bool UIMachineSettingsSFDetails::isPermanent() const
 {
-    return m_fUsePermanent ? mCbPermanent->isChecked() : true;
+    return m_fUsePermanent ? m_pPermanentCheckBox->isChecked() : true;
 }
 
 void UIMachineSettingsSFDetails::retranslateUi()
 {
-    /* Translate uic generated strings: */
-    Ui::UIMachineSettingsSFDetails::retranslateUi(this);
+    m_pPathLabel->setText(QApplication::translate("UIMachineSettingsSFDetails", "Folder Path:"));
+    m_pNameLabel->setText(QApplication::translate("UIMachineSettingsSFDetails", "Folder Name:"));
+    m_pNameLineEdit->setToolTip(QApplication::translate("UIMachineSettingsSFDetails", "Holds the name of the shared folder (as it will be seen by the guest OS)."));
+    m_pReadonlyCheckBox->setToolTip(QApplication::translate("UIMachineSettingsSFDetails", "When checked, the guest OS will not be able to write to the specified shared folder."));
+    m_pReadonlyCheckBox->setText(QApplication::translate("UIMachineSettingsSFDetails", "&Read-only"));
+    m_pAutoMountCheckBox->setToolTip(QApplication::translate("UIMachineSettingsSFDetails", "When checked, the guest OS will try to automatically mount the shared folder on startup."));
+    m_pAutoMountCheckBox->setText(QApplication::translate("UIMachineSettingsSFDetails", "&Auto-mount"));
+    m_pAutoMountPointLabel->setText(QApplication::translate("UIMachineSettingsSFDetails", "Mount point:"));
+    m_pAutoMountPointLineEdit->setToolTip(QApplication::translate("UIMachineSettingsSFDetails", "Where to automatically mount the folder in the guest.  A drive letter (e.g. 'G:') for Windows and OS/2 guests, path for the others.  If left empty the guest will pick something fitting."));
+    m_pPermanentCheckBox->setToolTip(QApplication::translate("UIMachineSettingsSFDetails", "When checked, this shared folder will be permanent."));
+    m_pPermanentCheckBox->setText(QApplication::translate("UIMachineSettingsSFDetails", "&Make Permanent"));
 
     switch (m_type)
@@ -145 +230 @@
 void UIMachineSettingsSFDetails::sltValidate()
 {
-    mButtonBox->button(QDialogButtonBox::Ok)->setEnabled(!mPsPath->path().isEmpty() &&
-                                                         QDir(mPsPath->path()).exists() &&
-                                                         !mLeName->text().trimmed().isEmpty() &&
-                                                         !mLeName->text().contains(" ") &&
-                                                         !m_usedNames.contains(mLeName->text()));
+    m_pButtonBox->button(QDialogButtonBox::Ok)->setEnabled(!m_pPathSelector->path().isEmpty() &&
+                                                         QDir(m_pPathSelector->path()).exists() &&
+                                                         !m_pNameLineEdit->text().trimmed().isEmpty() &&
+                                                         !m_pNameLineEdit->text().contains(" ") &&
+                                                         !m_usedNames.contains(m_pNameLineEdit->text()));
 }
 
 void UIMachineSettingsSFDetails::sltSelectPath()
 {
-    if (!mPsPath->isPathSelected())
+    if (!m_pPathSelector->isPathSelected())
         return;
 
-    QString strFolderName(mPsPath->path());
+    QString strFolderName(m_pPathSelector->path());
 #if defined (VBOX_WS_WIN) || defined (Q_OS_OS2)
     if (strFolderName[0].isLetter() && strFolderName[1] == ':' && strFolderName[2] == 0)
@@ -164 +249 @@
          * Append the trailing backslash to get a valid root path 'X:\': */
         strFolderName += "\\";
-        mPsPath->setPath(strFolderName);
+        m_pPathSelector->setPath(strFolderName);
     }
 #endif /* VBOX_WS_WIN || Q_OS_OS2 */
@@ -171 +256 @@
     {
         /* Processing non-root folder */
-        mLeName->setText(folder.dirName().replace(' ', '_'));
+        m_pNameLineEdit->setText(folder.dirName().replace(' ', '_'));
     }
     else
@@ -177 +262 @@
         /* Processing root folder: */
 #if defined (VBOX_WS_WIN) || defined (Q_OS_OS2)
-        mLeName->setText(strFolderName.toUpper()[0] + "_DRIVE");
+        m_pNameLineEdit->setText(strFolderName.toUpper()[0] + "_DRIVE");
 #elif defined (VBOX_WS_X11)
-        mLeName->setText("ROOT");
+        m_pNameLineEdit->setText("ROOT");
 #endif
     }

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSFDetails.h

@@ -23 +23 @@
 
 /* Includes */
-#include "UIMachineSettingsSFDetails.gen.h"
 #include "QIDialog.h"
 #include "QIWithRetranslateUI.h"
 #include "UIMachineSettingsSF.h"
 
+class UIFilePathSelector;
+class QCheckBox;
+class QLabel;
+class QLineEdit;
+class QIDialogButtonBox;
+
 /* Shared folders details dialog: */
-class SHARED_LIBRARY_STUFF UIMachineSettingsSFDetails : public QIWithRetranslateUI2<QIDialog>,
-                                                        public Ui::UIMachineSettingsSFDetails
+class SHARED_LIBRARY_STUFF UIMachineSettingsSFDetails : public QIWithRetranslateUI2<QIDialog>
 {
     Q_OBJECT;
@@ -76 +80 @@
 private:
 
+    void prepareWidgets();
+
     SFDialogType  m_type;
     bool          m_fUsePermanent;
     QStringList   m_usedNames;
+    UISettingsCacheSharedFolders *m_pCache;
+
+    /** @name Widgets
+      * @{ */
+        UIFilePathSelector *m_pPathSelector;
+        QCheckBox *m_pPermanentCheckBox;
+        QLineEdit *m_pNameLineEdit;
+        QCheckBox *m_pReadonlyCheckBox;
+        QCheckBox *m_pAutoMountCheckBox;
+        QLineEdit *m_pAutoMountPointLineEdit;
+        QLabel *m_pPathLabel;
+        QLabel *m_pNameLabel;
+        QLabel *m_pAutoMountPointLabel;
+        QIDialogButtonBox *m_pButtonBox;
+    /** @} */
 };