Changeset 85683 in vbox

Timestamp:

Aug 11, 2020 11:03:42 AM (4 years ago)

Author:

vboxsync

Message:

Main,FE,doc/VBoxManage+Host+SystemProperties+manual: bugref:7983: Move update check from GUI to API, add more data

Location:

trunk

Files:

• doc/manual/Config.kmk (modified) (1 diff)
• doc/manual/en_US/man_VBoxManage-updatecheck.xml (added)
• doc/manual/en_US/user_VBoxManage.xml (modified) (1 diff)
• include/VBox/log.h (modified) (2 diffs)
• include/VBox/settings.h (modified) (1 diff)
• src/VBox/Frontends/VBoxManage/Makefile.kmk (modified) (1 diff)
• src/VBox/Frontends/VBoxManage/VBoxManage.cpp (modified) (1 diff)
• src/VBox/Frontends/VBoxManage/VBoxManage.h (modified) (2 diffs)
• src/VBox/Frontends/VBoxManage/VBoxManageHelp.cpp (modified) (1 diff)
• src/VBox/Frontends/VBoxManage/VBoxManageList.cpp (modified) (1 diff)
• src/VBox/Frontends/VBoxManage/VBoxManageUpdateCheck.cpp (added)
• src/VBox/Main/Makefile.kmk (modified) (1 diff)
• src/VBox/Main/idl/VirtualBox.xidl (modified) (5 diffs)
• src/VBox/Main/include/HostImpl.h (modified) (2 diffs)
• src/VBox/Main/include/HostUpdateImpl.h (added)
• src/VBox/Main/include/SystemPropertiesImpl.h (modified) (2 diffs)
• src/VBox/Main/src-server/HostImpl.cpp (modified) (5 diffs)
• src/VBox/Main/src-server/HostUpdateImpl.cpp (added)
• src/VBox/Main/src-server/SystemPropertiesImpl.cpp (modified) (4 diffs)
• src/VBox/Main/xml/Settings.cpp (modified) (3 diffs)

trunk/doc/manual/Config.kmk

@@ -46 +46 @@
         man_VBoxManage-cloud.xml \
         man_VBoxManage-cloudprofile.xml \
-        man_VBoxManage-signova.xml
+        man_VBoxManage-signova.xml \
+        man_VBoxManage-updatecheck.xml
 
 ## List of user manual XML files.

trunk/doc/manual/en_US/user_VBoxManage.xml

@@ -8964 +8964 @@
   <xi:include href="user_man_VBoxManage-signova.xml"        xpointer="element(/1)" xmlns:xi="http://www.w3.org/2001/XInclude" />
 
+  <xi:include href="user_man_VBoxManage-updatecheck.xml" xpointer="element(/1)" xmlns:xi="http://www.w3.org/2001/XInclude" />
+
 <!-- TODO: Figure out how we can handle other manpages. The xml is bolted to
              sect1, so it's not possible to have them "in place" -->

trunk/include/VBox/log.h

@@ -477 +477 @@
     /** Main group, IHost. */
     LOG_GROUP_MAIN_HOST,
+    /** Main group, IHostUpdate. */
+    LOG_GROUP_MAIN_HOSTUPDATE,
     /** Main group, IHostNetworkInterface. */
     LOG_GROUP_MAIN_HOSTNETWORKINTERFACE,
@@ -979 +981 @@
     "MAIN_GUESTSESSIONEVENT", \
     "MAIN_HOST", \
+    "MAIN_HOSTUPDATE", \
     "MAIN_HOSTNETWORKINTERFACE", \
     "MAIN_HOSTUSBDEVICE", \

trunk/include/VBox/settings.h

@@ -325 +325 @@
     uint32_t                uLogHistoryCount;
     bool                    fExclusiveHwVirt;
+    bool                    fVBoxUpdateEnabled;
+    uint32_t                uVBoxUpdateCount;
+    uint32_t                uVBoxUpdateFrequency;
+    uint32_t                uVBoxUpdateTarget; /**< VBoxUpdateTarget_T */
+    com::Utf8Str            strVBoxUpdateLastCheckDate;
 };
 

trunk/src/VBox/Frontends/VBoxManage/Makefile.kmk

@@ -97 +97 @@
         VBoxManageSnapshot.cpp \
         VBoxManageStorageController.cpp \
+        VBoxManageUpdateCheck.cpp \
         VBoxManageUSB.cpp \
         $(if $(VBOX_WITH_NAT_SERVICE),VBoxManageNATNetwork.cpp,) \

trunk/src/VBox/Frontends/VBoxManage/VBoxManage.cpp

@@ -162 +162 @@
     { "usbdevsource",       USAGE_USBDEVSOURCE,     VBMG_CMD_TODO, handleUSBDevSource,         0 },
     { "cloudprofile",       USAGE_S_NEWCMD,      HELP_CMD_CLOUDPROFILE, handleCloudProfile,         0 },
-    { "cloud",              USAGE_S_NEWCMD,         HELP_CMD_CLOUD, handleCloud,               0 }
+    { "cloud",              USAGE_S_NEWCMD,         HELP_CMD_CLOUD, handleCloud,               0 },
+    { "updatecheck",        USAGE_UPDATECHECK,   HELP_CMD_UPDATECHECK, handleUpdateCheck,           0 }
 };
 

trunk/src/VBox/Frontends/VBoxManage/VBoxManage.h

@@ -110 +110 @@
     USAGE_USBDEVSOURCE,
     USAGE_CLOUDPROFILE,
+    USAGE_UPDATECHECK,
     /* Insert new entries before this line, but only if it is not an option
      * to go for the new style command and help handling (see e.g. extpack,
@@ -339 +340 @@
 RTEXITCODE handleCloud(HandlerArg *a);
 
+/* VBoxManageUpdateCheck.cpp */
+RTEXITCODE handleUpdateCheck(HandlerArg *a);
+
 #endif /* !VBOX_ONLY_DOCS */
 

trunk/src/VBox/Frontends/VBoxManage/VBoxManageHelp.cpp

@@ -1238 +1238 @@
     }
 
+    if (enmCommand == USAGE_UPDATECHECK || enmCommand == USAGE_S_ALL)
+    {
+        RTStrmPrintf(pStrm,
+                           "%s updatecheck %s     perform\n"
+                           "%s updatecheck %s     getsettings\n"
+                           "%s updatecheck %s     modifysettings [--enable|--disable]\n"
+                     "                                           [--target=stable|withbetas|allreleases]\n"
+                     "                                           [--frequency=<days>]\n"
+                     "\n", SEP, SEP, SEP);
+    }
+
 #ifndef VBOX_ONLY_DOCS /* Converted to man page, not needed. */
     if (enmCommand == USAGE_S_ALL)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageList.cpp

@@ -827 +827 @@
     systemProperties->COMGETTER(ProxyURL)(str.asOutParam());
     RTPrintf("Proxy URL:                       %ls\n", str.raw());
+    systemProperties->COMGETTER(VBoxUpdateEnabled)(&fValue);
+    RTPrintf("Update check enabled:            %s\n", fValue ? "yes" : "no");
+    systemProperties->COMGETTER(VBoxUpdateCount)(&ulValue);
+    RTPrintf("Update check count:              %u\n", ulValue);
+    systemProperties->COMGETTER(VBoxUpdateFrequency)(&ulValue);
+    if (ulValue == 0)
+        RTPrintf("Update check frequency:          never\n");
+    else if (ulValue == 1)
+        RTPrintf("Update check frequency:          every day\n");
+    else
+        RTPrintf("Update check frequency:          every %u days\n", ulValue);
+    VBoxUpdateTarget_T enmVBoxUpdateTarget;
+    systemProperties->COMGETTER(VBoxUpdateTarget)(&enmVBoxUpdateTarget);
+    switch (enmVBoxUpdateTarget)
+    {
+        case VBoxUpdateTarget_Stable:
+            psz = "Stable: new minor and maintenance releases";
+            break;
+        case VBoxUpdateTarget_AllReleases:
+            psz = "All releases: new minor, maintenance, and major releases";
+            break;
+        case VBoxUpdateTarget_WithBetas:
+            psz = "With Betas: new minor, maintenance, major, and beta releases";
+            break;
+        default:
+            psz = "Unset";
+            break;
+    }
+    RTPrintf("Update check target:             %s\n", psz);
+    systemProperties->COMGETTER(VBoxUpdateLastCheckDate)(str.asOutParam());
+    RTPrintf("Last check date:                 %ls\n", str.raw());
+ 
     return S_OK;
 }

trunk/src/VBox/Main/Makefile.kmk

@@ -579 +579 @@
         src-server/HostNetworkInterfaceImpl.cpp \
         src-server/HostPower.cpp \
+        src-server/HostUpdateImpl.cpp \
         src-server/HostVideoInputDeviceImpl.cpp \
         src-server/MachineImpl.cpp \

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -10225 +10225 @@
   </interface>
 
+  <enum
+    name="UpdateCheckType"
+    uuid="ac34bb91-6739-4791-b30f-ce84e57928bb"
+    >
+    <desc>
+      Which type of software to check whether a new version exists.
+    </desc>
+    <const name="None"              value="0">
+      <desc>No flags specified. Do not use this.</desc>
+    </const>
+    <const name="VirtualBox"        value="1"/>
+    <const name="ExtensionPack"     value="2"/>
+    <const name="GuestAdditions"    value="3"/>
+  </enum>
+
   <interface
     name="IHostUpdate" extends="$unknown"
@@ -10236 +10251 @@
       by <link to="IHost::update" /> attribute).
     </desc>
+
+    <method name="updateCheck">
+      <desc>
+        Check for a newer version of software based on the 'checkType' value.
+      </desc>
+      <param name="checkType" type="UpdateCheckType" dir="in">
+        <desc>The type of software to check.</desc>
+      </param>
+      <param name="progress" type="IProgress" dir="return">
+        <desc>Progress object to track operation completion.</desc>
+      </param>
+    </method>
+
+    <attribute name="updateResponse" type="boolean" readonly="yes">
+      <desc>
+        The response from the <link to="IHostUpdate::updateCheck"/> method.
+      </desc>
+    </attribute>
+
+    <attribute name="updateVersion" type="wstring" readonly="yes">
+      <desc>
+       The newer version of the software returned by calling the update check
+       <link to="IHostUpdate::updateCheck"/> method.
+      </desc>
+    </attribute>
+
+    <attribute name="updateURL" type="wstring" readonly="yes">
+      <desc>
+       The download URL of the newer software version returned by calling the
+       update check <link to="IHostUpdate::updateCheck"/> method.
+      </desc>
+    </attribute>
+
+    <attribute name="updateCheckNeeded" type="boolean" readonly="yes">
+      <desc>
+        Is it time to check for a newer version of software?
+      </desc>
+    </attribute>
 
   </interface>
@@ -10740 +10793 @@
 
     <attribute name="update" type="IHostUpdate" readonly="yes">
-      <desc>List of floppy drives available on the host.</desc>
+      <desc>The check for newer software object (singleton).</desc>
     </attribute>
 
@@ -10786 +10839 @@
   </enum>
 
+  <enum name="VBoxUpdateTarget" uuid="900d4a76-7b08-4af8-a453-f331e783eaee">
+    <desc> The preferred release type used for determining whether a newer version of VirtualBox is available. <link to="ISystemProperties::VBoxUpdateTarget"/></desc>
+    <const name="Stable" value="0">
+      <desc>Stable releases: new maintenance and minor releases within the same major release version.  This is the default.</desc>
+    </const>
+    <const name="AllReleases" value="1">
+      <desc>All releases: new maintenance, minor, and major releases.</desc>
+    </const>
+    <const name="WithBetas" value="2">
+      <desc>With betas: new maintenance, minor, and major releases as well as beta releases.</desc>
+    </const>
+  </enum>
+
   <interface
     name="ISystemProperties"
@@ -11315 +11381 @@
         Returns an array of officially supported values for enum <link to="ChipsetType"/>,
         in the sense of what is e.g. worth offering in the VirtualBox GUI.
+      </desc>
+    </attribute>
+
+    <attribute name="VBoxUpdateEnabled" type="boolean" readyonly="no">
+      <desc> Is the VirtualBox update check enabled?</desc>
+    </attribute>
+
+    <attribute name="VBoxUpdateFrequency" type="unsigned long" readonly="no">
+      <desc> How often should a check for a newer version of VirtualBox be made? (in days)</desc>
+    </attribute>
+
+    <attribute name="VBoxUpdateLastCheckDate" type="wstring" readonly="no">
+      <desc> 
+        When was the update check last performed? If updating this attribute the
+        string must be in ISO 8601 format (e.g. 2020-05-11T21:13:39.348416000Z).
+      </desc>
+    </attribute>
+
+    <attribute name="VBoxUpdateTarget" type="VBoxUpdateTarget" readonly="no">
+      <desc> The preferred release type used for determining whether a newer version of VirtualBox is available.</desc>
+    </attribute>
+
+    <attribute name="VBoxUpdateCount" type="unsigned long" readonly="no">
+      <desc> The count of update check attempts.</desc>
+    </attribute>
+
+    <attribute name="supportedVBoxUpdateTargetTypes" type="VBoxUpdateTarget" safearray="yes" readonly="yes">
+      <desc>
+        Returns an array of officially supported values for enum <link to="VBoxUpdateTarget"/>.
       </desc>
     </attribute>

trunk/src/VBox/Main/include/HostImpl.h

@@ -117 +117 @@
     HRESULT getVideoInputDevices(std::vector<ComPtr<IHostVideoInputDevice> > &aVideoInputDevices);
     HRESULT getUpdate(ComPtr<IHostUpdate> &aUpdate);
+    HRESULT getUpdateResponse(BOOL *aUpdateNeeded);
+    HRESULT getUpdateVersion(com::Utf8Str &aUpdateVersion);
+    HRESULT getUpdateURL(com::Utf8Str &aUpdateURL);
+    HRESULT getUpdateCheckNeeded(BOOL *aUpdateCheckNeeded);
 
     // wrapped IHost methods
@@ -161 +165 @@
 
     HRESULT removeUSBDeviceSource(const com::Utf8Str &aId);
+    HRESULT UpdateCheck(UpdateCheckType_T aCheckType,
+                        ComPtr<IProgress> &aProgress);
 
     // Internal Methods.

trunk/src/VBox/Main/include/SystemPropertiesImpl.h

@@ -142 +142 @@
     HRESULT getSupportedStorageControllerTypes(std::vector<StorageControllerType_T> &aSupportedStorageControllerTypes) RT_OVERRIDE;
     HRESULT getSupportedChipsetTypes(std::vector<ChipsetType_T> &aSupportedChipsetTypes) RT_OVERRIDE;
+    HRESULT getSupportedVBoxUpdateTargetTypes(std::vector<VBoxUpdateTarget_T> &aSupportedVBoxUpdateTargetTypes) RT_OVERRIDE;
+    HRESULT getVBoxUpdateEnabled(BOOL *aVBoxUpdateEnabled) RT_OVERRIDE;
+    HRESULT setVBoxUpdateEnabled(BOOL aVBoxUpdateEnabled) RT_OVERRIDE;
+    HRESULT getVBoxUpdateFrequency(ULONG *aVBoxUpdateFrequency) RT_OVERRIDE;
+    HRESULT setVBoxUpdateFrequency(ULONG aVBoxUpdateFrequency) RT_OVERRIDE;
+    HRESULT getVBoxUpdateLastCheckDate(com::Utf8Str &aVBoxUpdateLastCheckDate) RT_OVERRIDE;
+    HRESULT setVBoxUpdateLastCheckDate(const com::Utf8Str &aVBoxUpdateLastCheckDate) RT_OVERRIDE;
+    HRESULT getVBoxUpdateTarget(VBoxUpdateTarget_T *aVBoxUpdateTarget) RT_OVERRIDE;
+    HRESULT setVBoxUpdateTarget(VBoxUpdateTarget_T aVBoxUpdateTarget) RT_OVERRIDE;
+    HRESULT getVBoxUpdateCount(ULONG *aVBoxUpdateCount) RT_OVERRIDE;
+    HRESULT setVBoxUpdateCount(ULONG aVBoxUpdateCount) RT_OVERRIDE;
 
     // wrapped ISystemProperties methods
@@ -185 +196 @@
     HRESULT i_setDefaultAdditionsISO(const com::Utf8Str &aPath);
     HRESULT i_setDefaultFrontend(const com::Utf8Str &aDefaultFrontend);
+    HRESULT i_setVBoxUpdateLastCheckDate(const com::Utf8Str &aVBoxUpdateLastCheckDate);
 
     VirtualBox * const  mParent;

trunk/src/VBox/Main/src-server/HostImpl.cpp

@@ -46 +46 @@
 #include "LoggingNew.h"
 #include "Performance.h"
+#include "HostUpdateImpl.h"
 
 #include "MediumImpl.h"
@@ -229 +230 @@
     /** Startup syncing of persistent config in extra data */
     bool                    fPersistentConfigUpToDate;
+
+    /** The reference to the update check handler singleton. */
+    const ComObjPtr<HostUpdate> pHostUpdate;
 };
 
@@ -284 +288 @@
 
     m->hostDnsMonitorProxy.init(m->pParent);
+
+    hrc = unconst(m->pHostUpdate).createObject();
+    if (SUCCEEDED(hrc))
+        hrc = m->pHostUpdate->init(m->pParent);
+    AssertComRCReturn(hrc, hrc);
 
 #if defined(RT_OS_WINDOWS)
@@ -467 +476 @@
 
     m->hostDnsMonitorProxy.uninit();
+
+    if (m->pHostUpdate)
+    {
+        m->pHostUpdate->uninit();
+        unconst(m->pHostUpdate).setNull();
+    }
 
 #ifdef VBOX_WITH_USB
@@ -1940 +1955 @@
 HRESULT Host::getUpdate(ComPtr<IHostUpdate> &aUpdate)
 {
-    RT_NOREF(aUpdate);
-    ReturnComNotImplemented();
+    HRESULT hrc = m->pHostUpdate.queryInterfaceTo(aUpdate.asOutParam());
+    return hrc;
 }
 

trunk/src/VBox/Main/src-server/SystemPropertiesImpl.cpp

@@ -115 +115 @@
     m->fExclusiveHwVirt = true;
 #endif
+
+    m->fVBoxUpdateEnabled = true;
+    m->uVBoxUpdateCount = 0;
+    m->uVBoxUpdateFrequency = 1; // daily is the default
+    m->uVBoxUpdateTarget = VBoxUpdateTarget_Stable;
 
     HRESULT rc = S_OK;
@@ -1808 +1813 @@
 }
 
+HRESULT SystemProperties::getSupportedVBoxUpdateTargetTypes(std::vector<VBoxUpdateTarget_T> &aSupportedVBoxUpdateTargetTypes)
+{
+    static const VBoxUpdateTarget_T aVBoxUpdateTargetTypes[] =
+    {
+        VBoxUpdateTarget_Stable,
+        VBoxUpdateTarget_AllReleases,
+        VBoxUpdateTarget_WithBetas
+    };
+    aSupportedVBoxUpdateTargetTypes.assign(aVBoxUpdateTargetTypes,
+                                           aVBoxUpdateTargetTypes + RT_ELEMENTS(aVBoxUpdateTargetTypes));
+    return S_OK;
+}
+
 
 // public methods only for internal purposes
@@ -1841 +1859 @@
     m->uProxyMode        = data.uProxyMode;
     m->strProxyUrl       = data.strProxyUrl;
+
+    m->fVBoxUpdateEnabled               = data.fVBoxUpdateEnabled;
+    m->uVBoxUpdateFrequency             = data.uVBoxUpdateFrequency;
+    m->strVBoxUpdateLastCheckDate       = data.strVBoxUpdateLastCheckDate;
+    m->uVBoxUpdateTarget                = data.uVBoxUpdateTarget;
+    m->uVBoxUpdateCount                 = data.uVBoxUpdateCount;
 
     rc = i_setAutostartDatabasePath(data.strAutostartDatabasePath);
@@ -2182 +2206 @@
 }
 
+HRESULT SystemProperties::i_setVBoxUpdateLastCheckDate(const com::Utf8Str &aVBoxUpdateLastCheckDate)
+{
+    m->strVBoxUpdateLastCheckDate = aVBoxUpdateLastCheckDate;
+
+    return S_OK;
+}
+
+HRESULT SystemProperties::getVBoxUpdateEnabled(BOOL *aVBoxUpdateEnabled)
+{
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+
+    *aVBoxUpdateEnabled = m->fVBoxUpdateEnabled;
+
+    return S_OK;
+}
+
+HRESULT SystemProperties::setVBoxUpdateEnabled(BOOL aVBoxUpdateEnabled)
+{
+    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+    m->fVBoxUpdateEnabled = !!aVBoxUpdateEnabled;
+    alock.release();
+
+    // VirtualBox::i_saveSettings() needs vbox write lock
+    AutoWriteLock vboxLock(mParent COMMA_LOCKVAL_SRC_POS);
+    HRESULT rc = mParent->i_saveSettings();
+
+    return rc;
+}
+
+HRESULT SystemProperties::getVBoxUpdateCount(ULONG *VBoxUpdateCount)
+{
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+
+    *VBoxUpdateCount = m->uVBoxUpdateCount;
+
+    return S_OK;
+}
+
+HRESULT SystemProperties::setVBoxUpdateCount(ULONG VBoxUpdateCount)
+{
+    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+    m->uVBoxUpdateCount = VBoxUpdateCount;
+    alock.release();
+
+    // VirtualBox::i_saveSettings() needs vbox write lock
+    AutoWriteLock vboxLock(mParent COMMA_LOCKVAL_SRC_POS);
+    HRESULT rc = mParent->i_saveSettings();
+
+    return rc;
+}
+
+HRESULT SystemProperties::getVBoxUpdateFrequency(ULONG *aVBoxUpdateFrequency)
+{
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+
+    *aVBoxUpdateFrequency = m->uVBoxUpdateFrequency;
+
+    return S_OK;
+}
+
+HRESULT SystemProperties::setVBoxUpdateFrequency(ULONG aVBoxUpdateFrequency)
+{
+    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+    m->uVBoxUpdateFrequency = aVBoxUpdateFrequency;
+    alock.release();
+
+    // VirtualBox::i_saveSettings() needs vbox write lock
+    AutoWriteLock vboxLock(mParent COMMA_LOCKVAL_SRC_POS);
+    HRESULT rc = mParent->i_saveSettings();
+
+    return rc;
+}
+
+HRESULT SystemProperties::getVBoxUpdateTarget(VBoxUpdateTarget_T *aVBoxUpdateTarget)
+{
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+    VBoxUpdateTarget_T enmTarget = *aVBoxUpdateTarget = (VBoxUpdateTarget_T)m->uVBoxUpdateTarget;
+    AssertMsgReturn(enmTarget == VBoxUpdateTarget_Stable ||
+                    enmTarget == VBoxUpdateTarget_AllReleases ||
+                    enmTarget == VBoxUpdateTarget_WithBetas,
+                    ("enmTarget=%d\n", enmTarget), E_UNEXPECTED);
+    return S_OK;
+}
+
+HRESULT SystemProperties::setVBoxUpdateTarget(VBoxUpdateTarget_T aVBoxUpdateTarget)
+{
+    /* Validate input. */
+    switch (aVBoxUpdateTarget)
+    {
+        case VBoxUpdateTarget_Stable:
+        case VBoxUpdateTarget_AllReleases:
+        case VBoxUpdateTarget_WithBetas:
+            break;
+        default:
+            return setError(E_INVALIDARG, tr("Invalid Target value: %d"), (int)aVBoxUpdateTarget);
+    }
+
+    /* Set and write out settings. */
+    {
+        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+        m->uVBoxUpdateTarget = aVBoxUpdateTarget;
+    }
+    AutoWriteLock alock(mParent COMMA_LOCKVAL_SRC_POS); /* required for saving. */
+    return mParent->i_saveSettings();
+}
+
+HRESULT SystemProperties::getVBoxUpdateLastCheckDate(com::Utf8Str &aVBoxUpdateLastCheckDate)
+{
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+    aVBoxUpdateLastCheckDate = m->strVBoxUpdateLastCheckDate;
+    return S_OK;
+}
+
+HRESULT SystemProperties::setVBoxUpdateLastCheckDate(const com::Utf8Str &aVBoxUpdateLastCheckDate)
+{
+    /*
+     * Validate input.
+     */
+    Utf8Str const *pLastCheckDate = &aVBoxUpdateLastCheckDate;
+    RTTIMESPEC TimeSpec;
+
+    if (pLastCheckDate->isEmpty() || !RTTimeSpecFromString(&TimeSpec, pLastCheckDate->c_str()))
+        return setErrorBoth(E_INVALIDARG, VERR_INVALID_PARAMETER,
+                            tr("Invalid LastCheckDate value: '%s'. "
+                               "Must be in ISO 8601 format (e.g. 2020-05-11T21:13:39.348416000Z)"), pLastCheckDate->c_str());
+
+    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+    HRESULT rc = i_setVBoxUpdateLastCheckDate(aVBoxUpdateLastCheckDate);
+    alock.release();
+    if (SUCCEEDED(rc))
+    {
+        // VirtualBox::i_saveSettings() needs vbox write lock
+        AutoWriteLock vboxLock(mParent COMMA_LOCKVAL_SRC_POS);
+        rc = mParent->i_saveSettings();
+    }
+
+    return rc;
+}

trunk/src/VBox/Main/xml/Settings.cpp

@@ -1602 +1602 @@
     , uLogHistoryCount(3)
     , fExclusiveHwVirt(true)
+    , fVBoxUpdateEnabled(true)
+    , uVBoxUpdateCount(0)
+    , uVBoxUpdateFrequency(1)
+    , uVBoxUpdateTarget(VBoxUpdateTarget_Stable)
 {
 #if defined(RT_OS_DARWIN) || defined(RT_OS_WINDOWS) || defined(RT_OS_SOLARIS)
@@ -2246 +2250 @@
                             fCopyProxySettingsFromExtraData = true;
                         pelmGlobalChild->getAttributeValue("proxyUrl", systemProperties.strProxyUrl);
+                        pelmGlobalChild->getAttributeValue("VBoxUpdateEnabled", systemProperties.fVBoxUpdateEnabled);
+                        pelmGlobalChild->getAttributeValue("VBoxUpdateCount", systemProperties.uVBoxUpdateCount);
+                        pelmGlobalChild->getAttributeValue("VBoxUpdateFrequency", systemProperties.uVBoxUpdateFrequency);
+                        pelmGlobalChild->getAttributeValue("VBoxUpdateTarget", systemProperties.uVBoxUpdateTarget);
+                        pelmGlobalChild->getAttributeValue("VBoxUpdateLastCheckDate",
+                            systemProperties.strVBoxUpdateLastCheckDate);
                     }
                     else if (pelmGlobalChild->nameEquals("ExtraData"))
@@ -2458 +2468 @@
     pelmSysProps->setAttribute("proxyMode", systemProperties.uProxyMode);
     pelmSysProps->setAttribute("exclusiveHwVirt", systemProperties.fExclusiveHwVirt);
+    pelmSysProps->setAttribute("VBoxUpdateEnabled", systemProperties.fVBoxUpdateEnabled);
+    pelmSysProps->setAttribute("VBoxUpdateCount", systemProperties.uVBoxUpdateCount);
+    pelmSysProps->setAttribute("VBoxUpdateFrequency", systemProperties.uVBoxUpdateFrequency);
+    pelmSysProps->setAttribute("VBoxUpdateTarget", systemProperties.uVBoxUpdateTarget);
+    if (systemProperties.strVBoxUpdateLastCheckDate.length())
+        pelmSysProps->setAttribute("VBoxUpdateLastCheckDate", systemProperties.strVBoxUpdateLastCheckDate);
 
     buildUSBDeviceFilters(*pelmGlobal->createChild("USBDeviceFilters"),