Changeset 8601 in vbox for trunk

Timestamp:

May 5, 2008 2:39:39 PM (17 years ago)

Author:

vboxsync

Message:

r=bird: Please rename the function pointers to g_pfnLibDlpi*.

File:

• trunk/src/VBox/Devices/Network/solaris/vbox-libdlpi.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Network/solaris/vbox-libdlpi.cpp

@@ -29 +29 @@
  * and symbols have been successfully loaded.
  */
-static RTLDRMOD ghLibDlpi = NULL;
+static RTLDRMOD g_hLibDlpi = NULL;
 
 /**
@@ -36 +36 @@
  * or failed to load something and unloaded.
  */
-static bool gCheckedForLibDlpi = false;
+static bool g_fCheckedForLibDlpi = false;
 
-/** 
- * All the symbols we need from libdlpi.
+/** All the symbols we need from libdlpi.
+ * @todo r=bird: rename to g_pfnLibDlpi*.
+ * @{
  */
 int (*gLibDlpiOpen)(const char *, dlpi_handle_t *, uint_t);
@@ -49 +50 @@
 int (*gLibDlpiRecv)(dlpi_handle_t, void *, size_t *, void *, size_t *, int, dlpi_recvinfo_t *);
 int (*gLibDlpiFd)(dlpi_handle_t);
+/** @} */
 
 bool gLibDlpiFound(void)
@@ -54 +56 @@
     RTLDRMOD hLibDlpi;
 
-    if (ghLibDlpi && gCheckedForLibDlpi == true)
+    if (g_hLibDlpi && g_fCheckedForLibDlpi)
         return true;
-    if (gCheckedForLibDlpi == true)
+    if (g_fCheckedForLibDlpi)
         return false;
     if (!RT_SUCCESS(RTLdrLoad(LIB_DLPI, &hLibDlpi)))
-    {
         return false;
-    }
     if (   RT_SUCCESS(RTLdrGetSymbol(hLibDlpi, "dlpi_open", (void **)&gLibDlpiOpen))
         && RT_SUCCESS(RTLdrGetSymbol(hLibDlpi, "dlpi_close", (void **)&gLibDlpiClose))
@@ -72 +72 @@
        )
     {
-        ghLibDlpi = hLibDlpi;
-        gCheckedForLibDlpi = true;
+        g_hLibDlpi = hLibDlpi;
+        g_fCheckedForLibDlpi = true;
         return true;
     }
@@ -79 +79 @@
     {
         RTLdrClose(hLibDlpi);
-        gCheckedForLibDlpi = true;
+        g_fCheckedForLibDlpi = true;
         return false;
-    }    
+    }
 }