Changeset 86201 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Sep 21, 2020 2:36:27 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: UIVirtualMachineItemCloud: Allow to wait for a cloud machine refresh task completeness in a blocking call (which doesn't block event porocessing ofc).

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIVirtualMachineItemCloud.cpp (modified) (5 diffs)
• UIVirtualMachineItemCloud.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualMachineItemCloud.cpp

@@ -17 +17 @@
 
 /* Qt includes: */
+#include <QPointer>
 #include <QTimer>
 
@@ -40 +41 @@
     , m_enmFakeCloudItemState(enmState)
     , m_pTask(0)
+    , m_pEventLoop(0)
 {
     recache();
@@ -50 +52 @@
     , m_enmFakeCloudItemState(UIFakeCloudVirtualMachineItemState_NotApplicable)
     , m_pTask(0)
+    , m_pEventLoop(0)
 {
     recache();
@@ -73 +76 @@
 {
     QTimer::singleShot(fDelayed ? 10000 : 0, this, SLOT(sltCreateGetCloudInstanceInfoTask()));
+}
+
+void UIVirtualMachineItemCloud::waitForAsyncInfoUpdateFinished()
+{
+    /* Make sure task is really created: */
+    if (!m_pTask)
+        return;
+
+    /* Cancel the task: */
+    m_pTask->cancel();
+
+    /* We are creating a locally-scoped event-loop object,
+     * but holding a pointer to it for a control needs: */
+    QEventLoop eventLoop;
+    m_pEventLoop = &eventLoop;
+
+    /* Guard ourself for the case
+     * we self-destroyed in our event-loop: */
+    QPointer<UIVirtualMachineItemCloud> guard = this;
+
+    /* Start the blocking event-loop: */
+    eventLoop.exec();
+
+    /* Event-loop object unblocked,
+     * Are we still valid? */
+    if (guard.isNull())
+        return;
+
+    /* Cleanup the pointer finally: */
+    m_pEventLoop = 0;
 }
 
@@ -301 +334 @@
     recache();
 
-    /* Notify listeners finally: */
-    emit sigStateChange();
-}
+    /* Exit from the event-loop if there is any: */
+    if (m_pEventLoop)
+        m_pEventLoop->exit();
+    /* Notify listeners otherwise: */
+    else
+        emit sigStateChange();
+}

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualMachineItemCloud.h

@@ -31 +31 @@
 /* Forward declarations: */
 class UITask;
+class UITaskCloudRefreshMachineInfo;
 
 /** UIVirtualMachineItem sub-class used as cloud Virtual Machine item interface. */
@@ -74 +75 @@
         /** Updates cloud VM info async way, @a fDelayed if requested or instant otherwise. */
         void updateInfoAsync(bool fDelayed);
+        /** Makes sure async info update is finished.
+          * @note  This method creates own event-loop to avoid blocking calling thread event processing,
+          *        so it's safe to call it from the GUI thread, ofc the method itself will be blocked. */
+        void waitForAsyncInfoUpdateFinished();
     /** @} */
 
@@ -142 +147 @@
 
         /** Holds the info acquire task instance. */
-        UITask *m_pTask;
+        UITaskCloudRefreshMachineInfo *m_pTask;
+        /** Holds the task waiting loop instance. */
+        QEventLoop                    *m_pEventLoop;
     /** @} */
 };