Changeset 86257 in vbox

Timestamp:

Sep 24, 2020 10:01:42 AM (4 years ago)

Author:

vboxsync

Message:

xpcom/xptcall: Implemented XPTC_InvokeByIndex in assembly (YASM) as the original mozilla code is making too many assumptions about how the compiler will compile the code. This already broke with gcc 8.2 and asan (bugref:8019) and now Clang breaks it (bugref:9790) when stack is needed for passing parameters. Code has received minimal testing, the floating point stuff isn't tested as we don't use that (I hope). bugref:9790

Location:

trunk/src/libs/xpcom18a4

Files:

• Config.kmk (modified) (1 diff)
• xpcom/Makefile.kup (added)
• xpcom/reflect/Makefile.kup (added)
• xpcom/reflect/xptcall/Makefile.kup (added)
• xpcom/reflect/xptcall/src/Makefile.kup (added)
• xpcom/reflect/xptcall/src/md/Makefile.kup (added)
• xpcom/reflect/xptcall/src/md/unix/Makefile.kup (added)
• xpcom/reflect/xptcall/src/md/unix/xptcinvoke_amd64_vbox.asm (added)

trunk/src/libs/xpcom18a4/Config.kmk

@@ -154 +154 @@
 # When using IPRT in NSRP or/and using IPRT for logging, link with IPRT.
 TEMPLATE_XPCOM_LIBS               += $(LIB_RUNTIME)
+
+
+#
+# Same as XPCOM except using YASM/NASM instead of the gnu/unix assembler.
+#
+TEMPLATE_XPCOMYASM = XPCOM w/ yasm
+TEMPLATE_XPCOMYASM_EXTENDS = XPCOM
+TEMPLATE_XPCOMYASM_ASTOOL        = $(TEMPLATE_VBOXR3NP_ASTOOL)
+TEMPLATE_XPCOMYASM_ASFLAGS       = $(TEMPLATE_VBOXR3NP_ASFLAGS)
+TEMPLATE_XPCOMYASM_ASFLAGS.x86   = $(TEMPLATE_VBOXR3NP_ASFLAGS.x86)
+TEMPLATE_XPCOMYASM_ASFLAGS.amd64 = $(TEMPLATE_VBOXR3NP_ASFLAGS.amd64)
+TEMPLATE_XPCOMYASM_ASDEFS        = $(TEMPLATE_VBOXR3NP_DEFS)
+
 
 #