Changeset 86258 in vbox

Timestamp:

Sep 24, 2020 10:06:36 AM (4 years ago)

Author:

vboxsync

Message:

xpcom/xptcall: Implemented XPTC_InvokeByIndex in assembly (YASM) as the original mozilla code is making too many assumptions about how the compiler will compile the code. This already broke with gcc 8.2 and asan (bugref:8019) and now Clang breaks it (bugref:9790) when stack is needed for passing parameters. Code has received minimal testing, the floating point stuff isn't tested as we don't use that (I hope). [file header] bugref:9790

File:

• trunk/src/libs/xpcom18a4/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_amd64_vbox.asm (modified) (1 diff)

trunk/src/libs/xpcom18a4/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_amd64_vbox.asm

@@ +1 @@
+; $Id$
+;; @file
+; XPCOM - Implementation XPTC_InvokeByIndex in assembly.
+;
+; This solves the problem of Clang and gcc (sometimes) not playing along with
+; the alloca() based trick to pass stack parameters.  We first had trouble
+; when enabling asan with gcc 8.2, then Clang 11 on mac had similar issues
+; (at least for profile builds).
+;
+
+;
+; Copyright (C) 2020 Oracle Corporation
+;
+; This file is part of VirtualBox Open Source Edition (OSE), as
+; available from http://www.virtualbox.org. This file is free software;
+; you can redistribute it and/or modify it under the terms of the GNU
+; General Public License (GPL) as published by the Free Software
+; Foundation, in version 2 as it comes in the "COPYING" file of the
+; VirtualBox OSE distribution. VirtualBox OSE is distributed in the
+; hope that it will be useful, but WITHOUT ANY WARRANTY of any kind.
+;