Changeset 86297 in vbox for trunk

Timestamp:

Sep 25, 2020 9:07:10 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

140574

Message:

xpcom/python/xptcall: shut up warning about memsetting objects.

Location:

trunk/src/libs/xpcom18a4

Files:

• python/src/VariantUtils.cpp (modified) (1 diff)
• xpcom/reflect/xptcall/public/xptcall.h (modified) (1 diff)

trunk/src/libs/xpcom18a4/python/src/VariantUtils.cpp

@@ -1228 +1228 @@
         m_var_array = new nsXPTCVariant[m_num_array];
         if (!m_var_array) goto done;
-        memset(m_var_array, 0, m_num_array * sizeof(m_var_array[0]));
+        /*memset(m_var_array, 0, m_num_array * sizeof(m_var_array[0])); - VBox not needed */
 
         m_buffer_array = new void *[m_num_array];

trunk/src/libs/xpcom18a4/xpcom/reflect/xptcall/public/xptcall.h

@@ -142 +142 @@
         VAL_IS_CSTR    = 0x40  // val.p holds a pointer to cstring needing cleanup        
     };
+
+    /* VBox: Added to prevent -Wclass-memaccess warnings (nsXPTType has a constructor) in python/src/VariantUtils.cpp */
+    nsXPTCVariant() : ptr(NULL), flags(0)
+    {
+        val.p = NULL;
+        type.flags = 0; /* stupid nsXPTType constructor only do random bytes (documented) */
+    }
 
     void ClearFlags()         {flags = 0;}