Changeset 86318 in vbox for trunk

Timestamp:

Sep 28, 2020 12:33:34 PM (4 years ago)

Author:

vboxsync

Message:

GA:Linux: bugref:9671 Non-security issue with our Linux GA binaries

Location:

trunk

Files:

• Config.kmk (modified) (1 diff)
• src/VBox/Additions/x11/VBoxClient/display-drm.cpp (modified) (2 diffs)

trunk/Config.kmk

@@ -7516 +7516 @@
 TEMPLATE_NewVBoxGuestR3Exe_LIBS += contract
 endif
+# Use PIE and RELRO for the GA executables to support ASLR in the guest
+TEMPLATE_NewVBoxGuestR3Exe_CXXFLAGS.linux       += -fPIE
+TEMPLATE_NewVBoxGuestR3Exe_CFLAGS.linux         += -fPIE
+TEMPLATE_NewVBoxGuestR3Exe_LDFLAGS.linux        += -pie -fPIE -Wl,-z,relro,-z,now,-z,noexecstack
 
 #

trunk/src/VBox/Additions/x11/VBoxClient/display-drm.cpp

@@ -162 +162 @@
                          unsigned cHeads)
 {
-    uid_t guid = getuid();
-    if (setreuid(0, 0) == -1)
+    uid_t curuid = getuid();
+    if (setreuid(0, 0) != 0)
         perror("setreuid failed during drm ioctl.");
     int rc;
@@ -176 +176 @@
     if (RT_FAILURE(rc) && rc != VERR_INVALID_PARAMETER)
         VBClLogFatalError("Failure updating layout, rc=%Rrc\n", rc);
-    setreuid(guid, 0);
+    if (setreuid(curuid, 0) != 0)
+        perror("reset of setreuid failed after drm ioctl.");
 }