Changeset 86318 in vbox for trunk/src/VBox/Additions/x11/VBoxClient

Timestamp:

Sep 28, 2020 12:33:34 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

140604

Message:

GA:Linux: bugref:9671 Non-security issue with our Linux GA binaries

File:

• trunk/src/VBox/Additions/x11/VBoxClient/display-drm.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/x11/VBoxClient/display-drm.cpp

@@ -162 +162 @@
                          unsigned cHeads)
 {
-    uid_t guid = getuid();
-    if (setreuid(0, 0) == -1)
+    uid_t curuid = getuid();
+    if (setreuid(0, 0) != 0)
         perror("setreuid failed during drm ioctl.");
     int rc;
@@ -176 +176 @@
     if (RT_FAILURE(rc) && rc != VERR_INVALID_PARAMETER)
         VBClLogFatalError("Failure updating layout, rc=%Rrc\n", rc);
-    setreuid(guid, 0);
+    if (setreuid(curuid, 0) != 0)
+        perror("reset of setreuid failed after drm ioctl.");
 }