Changeset 86322 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Sep 28, 2020 2:44:14 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: UIMainEventListener: A bit of cleanup related to source/listener [un]registration.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/globals

Files:

• UIMainEventListener.cpp (modified) (5 diffs)
• UIMainEventListener.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMainEventListener.cpp

@@ -80 +80 @@
 public:
 
-    /** Constructs Main events listener thread redirecting events from @a comSource to @a comListener. */
-    UIMainEventListeningThread(const CEventSource &comSource, const CEventListener &comListener);
+    /** Constructs Main events listener thread redirecting events from @a comSource to @a comListener.
+      * @param  comSource    Brings event source we are creating this thread for.
+      * @param  comListener  Brings event listener we are creating this thread for. */
+    UIMainEventListeningThread(const CEventSource &comSource,
+                               const CEventListener &comListener);
     /** Destructs Main events listener thread. */
-    ~UIMainEventListeningThread();
+    virtual ~UIMainEventListeningThread() /* override */;
 
 protected:
@@ -98 +101 @@
 
     /** Holds the Main event source reference. */
-    CEventSource m_comSource;
+    CEventSource          m_comSource;
     /** Holds the Main event listener reference. */
-    CEventListener m_comListener;
+    CEventListener        m_comListener;
 
     /** Holds the mutex instance which protects thread access. */
@@ -113 +116 @@
 *********************************************************************************************************************************/
 
-UIMainEventListeningThread::UIMainEventListeningThread(const CEventSource &comSource, const CEventListener &comListener)
+UIMainEventListeningThread::UIMainEventListeningThread(const CEventSource &comSource,
+                                                       const CEventListener &comListener)
     : m_comSource(comSource)
     , m_comListener(comListener)
@@ -201 +205 @@
 }
 
-void UIMainEventListener::registerSource(const CEventSource &comSource, const CEventListener &comListener)
+void UIMainEventListener::registerSource(const CEventSource &comSource,
+                                         const CEventListener &comListener)
 {
     /* Make sure source and listener are valid: */
@@ -208 +213 @@
 
     /* Create thread for passed source: */
-    m_threads << new UIMainEventListeningThread(comSource, comListener);
-    /* And start it: */
-    m_threads.last()->start();
+    UIMainEventListeningThread *pThread = new UIMainEventListeningThread(comSource, comListener);
+    if (pThread)
+    {
+        /* Register & start it: */
+        m_threads << pThread;
+        pThread->start();
+    }
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMainEventListener.h

@@ -209 +209 @@
     void uninit() {}
 
-    /** Registers event @a source for passive event @a listener. */
-    void registerSource(const CEventSource &comSource, const CEventListener &comListener);
+    /** Registers event source for passive event listener by creating a listening thread.
+      * @param  comSource    Brings event source we are creating listening thread for.
+      * @param  comListener  Brings event listener we are creating listening thread for. */
+    void registerSource(const CEventSource &comSource,
+                        const CEventListener &comListener);
     /** Unregisters event sources. */
     void unregisterSources();