Changeset 86378 in vbox for trunk/src/VBox/Runtime/common/string

Timestamp:

Oct 1, 2020 1:59:14 PM (4 years ago)

Author:

vboxsync

Message:

IPRT/RTStrToInt64Ex: Shut up tstRTCRest-1 asan warning reading INT64_MIN. bugref:9841

File:

• trunk/src/VBox/Runtime/common/string/strtonum.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/string/strtonum.cpp

@@ -634 +634 @@
     }
 
-    if (   !(u64 & RT_BIT_64(63))
-        || (!fPositive && u64 == RT_BIT_64(63)) )
-    { /* likely */ }
+    /* Mixing pi64 assigning and overflow checks is to pacify a tstRTCRest-1
+       asan overflow warning.  */
+    if (!(u64 & RT_BIT_64(63)))
+    {
+        if (psz == pszValue)
+            rc = VERR_NO_DIGITS;
+        if (pi64)
+            *pi64 = fPositive ? u64 : -(int64_t)u64;
+    }
+    else if (!fPositive && u64 == RT_BIT_64(63))
+    {
+        if (pi64)
+            *pi64 = INT64_MIN;
+    }
     else
+    {
         rc = VWRN_NUMBER_TOO_BIG;
-
-    if (pi64)
-        *pi64 = fPositive ? u64 : -(int64_t)u64;
-
-    if (psz == pszValue)
-        rc = VERR_NO_DIGITS;
+        if (pi64)
+            *pi64 = fPositive ? u64 : -(int64_t)u64;
+    }
 
     if (ppszNext)