Changeset 86398 in vbox

Timestamp:

Oct 1, 2020 7:03:08 PM (4 years ago)

Author:

vboxsync

Message:

xpcom/TestCOMPtr: Fixed use-after-free issue in IFoo::Release. bugref:9841

File:

• trunk/src/libs/xpcom18a4/xpcom/tests/TestCOMPtr.cpp (modified) (2 diffs)

trunk/src/libs/xpcom18a4/xpcom/tests/TestCOMPtr.cpp

@@ -158 +158 @@
       printf(">>");
       
-    --refcount_;
+    nsrefcnt const newcount = --refcount_;
     printf("IFoo@%p::Release(), refcount --> %d\n",
-           STATIC_CAST(void*, this), refcount_);
-
-    if ( !refcount_ )
+           STATIC_CAST(void*, this), newcount);
+
+    if ( !newcount )
       {
         printf("  delete IFoo@%p\n", STATIC_CAST(void*, this));
@@ -171 +171 @@
       printf("<<IFoo@%p::Release()\n", STATIC_CAST(void*, this));
 
-    return refcount_;
+    return newcount;
   }