Changeset 86417 in vbox for trunk/src/libs/xpcom18a4/xpcom/tests/TestHashtables.cpp

Timestamp:

Oct 2, 2020 11:54:57 AM (4 years ago)

Author:

vboxsync

Message:

xpcom/TestHashTables: Fixed use-after-free issue in IFoo::Release(). bugref:9841

File:

• trunk/src/libs/xpcom18a4/xpcom/tests/TestHashtables.cpp (modified) (2 diffs)

trunk/src/libs/xpcom18a4/xpcom/tests/TestHashtables.cpp

@@ -290 +290 @@
       printf(">>");
       
-    --refcount_;
+    nsrefcnt = --refcount_;
     printf("IFoo@%p::Release(), refcount --> %d\n",
-           NS_STATIC_CAST(void*, this), refcount_);
-
-    if ( !refcount_ )
+           NS_STATIC_CAST(void*, this), nsrefcnt);
+
+    if ( !nsrefcnt )
       {
         printf("  delete IFoo@%p\n", NS_STATIC_CAST(void*, this));
@@ -303 +303 @@
       printf("  delete IFoo@%p\n", NS_STATIC_CAST(void*, this));
 
-    return refcount_;
+    return nsrefcnt;
   }