Changeset 86498 in vbox for trunk/src

Timestamp:

Oct 8, 2020 5:00:21 PM (4 years ago)

Author:

vboxsync

Message:

VBoxSVC/MachineImpl.cpp: Fixed use-after-free problem in Machine::i_prepareSaveSettings where a Utf8Str::printf was fed its old value as one of the format argument. bugref:9841

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -9605 +9605 @@
             {
                 /* get the path to old settings file in renamed directory */
+                Assert(mData->m_strConfigFileFull == configFile);
                 configFile.printf("%s%c%s",
                                   newConfigDir.c_str(),
                                   RTPATH_DELIMITER,
-                                  RTPathFilename(configFile.c_str()));
+                                  RTPathFilename(mData->m_strConfigFileFull.c_str()));
                 if (!fSettingsFileIsNew)
                 {