Changeset 86503 in vbox for trunk/src/VBox

Timestamp:

Oct 9, 2020 1:49:47 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

140818

Message:

ValKit/vbox.py: VBoxSVC failure should be checked and reported. bugref:9841

Location:

trunk/src/VBox/ValidationKit/testdriver

Files:

• base.py (modified) (1 diff)
• vbox.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/testdriver/base.py

@@ -737 +737 @@
             return -127;
         return self.uExitCode >> 8;
+
+    def isNormalExit(self):
+        """
+        Returns True if regular exit(), False if signal or still running.
+        """
+        if self.isRunning():
+            return False;
+        if sys.platform == 'win32':
+            return False;
+        return os.WIFEXITED(self.uExitCode);
 
     def interrupt(self):

trunk/src/VBox/ValidationKit/testdriver/vbox.py

@@ -1318 +1318 @@
                 reporter.log('VBoxSVC is no longer running...');
             if not self.oVBoxSvcProcess.isRunning():
+                iExit = self.oVBoxSvcProcess.getExitCode();
+                if iExit != 0 or not self.oVBoxSvcProcess.isNormalExit():
+                    reporter.error("VBoxSVC exited with status %d (%#x)" % (iExit, self.oVBoxSvcProcess.uExitCode));
                 self.oVBoxSvcProcess = None;
         else: