Changeset 86514 in vbox

Timestamp:

Oct 10, 2020 1:07:10 PM (4 years ago)

Author:

vboxsync

Message:

VBoxSVC/VirtualBoxImpl.cpp: update @todo from r140816. bugref:9841

File:

• trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp

@@ -936 +936 @@
             /** @todo r=bird: should we really do notifications for duplicates?
              *  ((Medium *)pHardDisk != (Medium *)pHardDiskActual)
-             * The problem with that, though, is that for the children we don't quite know 
-             * which are duplicates and which aren't.   The above initFromSettings is 
-             * essentially a merge operation now, so in the duplicate case, we may just 
-             * have added a new (grand)child. */ 
+             * The problem with that, though, is that for the children we don't quite know
+             * which are duplicates and which aren't.   The above initFromSettings is
+             * essentially poforming a merge operation now, so in the duplicate case, we may
+             * just have added a new (grand)child.  Why don't we just pass uIdsForNotify
+             * down to initFromSettings, that'll save us this extra walking? */
 
             uIdsForNotify.push_back(std::pair<Guid, DeviceType_T>(pHardDiskActual->i_getId(), DeviceType_HardDisk));