Changeset 86574 in vbox for trunk/src/VBox

Timestamp:

Oct 14, 2020 12:47:10 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

140928

Message:

Dev/E1000: (bugref:9829) Fixed division-by-zero issues

File:

• trunk/src/VBox/Devices/Network/DevE1000.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -3948 +3948 @@
     unsigned nDescsToFetch      = RT_MIN(nDescsAvailable, E1K_TXD_CACHE_SIZE - pThis->nTxDFetched);
     unsigned nDescsTotal        = TDLEN / sizeof(E1KTXDESC);
+    Assert(nDescsTotal != 0);
+    if (nDescsTotal == 0)
+        return 0;
     unsigned nFirstNotLoaded    = (TDH + pThis->nTxDFetched) % nDescsTotal;
     unsigned nDescsInSingleRead = RT_MIN(nDescsToFetch, nDescsTotal - nFirstNotLoaded);
@@ -5463 +5466 @@
         if (i == pThis->iTxDCurrent)
             LogRel(("E1000: >>> "));
-        LogRel(("E1000: %RGp: %R[e1ktxd]\n", e1kDescAddr(TDBAH, TDBAL, tdh++ % cDescs), &pThis->aTxDescriptors[i]));
+        if (cDescs)
+            LogRel(("E1000: %RGp: %R[e1ktxd]\n", e1kDescAddr(TDBAH, TDBAL, tdh++ % cDescs), &pThis->aTxDescriptors[i]));
+        else
+            LogRel(("E1000: <lost>: %R[e1ktxd]\n", &pThis->aTxDescriptors[i]));
     }
 }
@@ -7345 +7351 @@
         if (i == pThis->iRxDCurrent)
             pHlp->pfnPrintf(pHlp, ">>> ");
-        pHlp->pfnPrintf(pHlp, "%RGp: %R[e1krxd]\n",
-                        e1kDescAddr(RDBAH, RDBAL, rdh++ % cDescs),
-                        &pThis->aRxDescriptors[i]);
+        if (cDescs)
+            pHlp->pfnPrintf(pHlp, "%RGp: %R[e1krxd]\n",
+                            e1kDescAddr(RDBAH, RDBAL, rdh++ % cDescs),
+                            &pThis->aRxDescriptors[i]);
+        else
+            pHlp->pfnPrintf(pHlp, "<lost>: %R[e1krxd]\n",
+                            &pThis->aRxDescriptors[i]);
     }
 #endif /* E1K_WITH_RXD_CACHE */
@@ -7374 +7384 @@
         if (i == pThis->iTxDCurrent)
             pHlp->pfnPrintf(pHlp, ">>> ");
-        pHlp->pfnPrintf(pHlp, "%RGp: %R[e1ktxd]\n",
-                        e1kDescAddr(TDBAH, TDBAL, tdh++ % cDescs),
-                        &pThis->aTxDescriptors[i]);
+        if (cDescs)
+            pHlp->pfnPrintf(pHlp, "%RGp: %R[e1ktxd]\n",
+                            e1kDescAddr(TDBAH, TDBAL, tdh++ % cDescs),
+                            &pThis->aTxDescriptors[i]);
+        else
+            pHlp->pfnPrintf(pHlp, "<lost>: %R[e1ktxd]\n",
+                            &pThis->aTxDescriptors[i]);
     }
 #endif /* E1K_WITH_TXD_CACHE */