Changeset 8661 in vbox for trunk/src

Timestamp:

May 7, 2008 2:40:30 PM (17 years ago)

Author:

vboxsync

Message:

Another attempt - don't call rtThreadRemove twice and if we do call it, make sure cRefs != 0.

File:

• trunk/src/VBox/Runtime/common/misc/thread.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/misc/thread.cpp

@@ -526 +526 @@
     /*
      * Remove it from the tree and mark it as dead.
-     */
-    rtThreadRemove(pThread);
+     *
+     * Thread that has seen rtThreadTerminate and entered the final TERMINATED
+     * state does not need removing, probably no thread should require removing
+     * here. However, be careful making sure that cRefs isn't 0 if we do or we'll
+     * blow up because the strict locking code will be calling us back.
+     */
+    if (pThread->enmState != RTTHREADSTATE_TERMINATED)
+    {
+        ASMAtomicIncU32(&pThread->cRefs);
+        rtThreadRemove(pThread);
+        ASMAtomicDecU32(&pThread->cRefs);
+    }
     ASMAtomicXchgU32(&pThread->u32Magic, RTTHREADINT_MAGIC_DEAD);