Changeset 86769 in vbox for trunk/src/VBox/Frontends

Timestamp:

Oct 30, 2020 12:27:58 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Chooser pane: More strict control over the selected cloud item refresh.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIVirtualBoxManagerWidget.cpp (modified) (1 diff)
• chooser/UIChooserItemMachine.cpp (modified) (2 diffs)
• chooser/UIChooserItemMachine.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManagerWidget.cpp

@@ -1007 +1007 @@
         if (pItem->itemType() == UIVirtualMachineItemType_Local)
             m_pPaneToolsMachine->setMachine(pItem->toLocal()->machine());
-        /* Update current cloud machine state: */
-        if (pItem->itemType() == UIVirtualMachineItemType_CloudReal)
-            pItem->toCloud()->updateInfoAsync(false /* delayed? */);
     }
     else

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItemMachine.cpp

@@ -31 +31 @@
 #include "UIIconPool.h"
 #include "UIVirtualBoxManager.h"
+#include "UIVirtualMachineItemCloud.h"
 #include "UIVirtualMachineItemLocal.h"
 
@@ -221 +222 @@
 }
 
+void UIChooserItemMachine::setSelected(bool fSelected)
+{
+    /* Call to base-class: */
+    UIChooserItem::setSelected(fSelected);
+
+    /* Special treatment for real cloud items: */
+    if (cacheType() == UIVirtualMachineItemType_CloudReal)
+    {
+        UIVirtualMachineItemCloud *pCloudMachineItem = cache()->toCloud();
+        AssertPtrReturnVoid(pCloudMachineItem);
+        if (fSelected && pCloudMachineItem->accessible())
+            pCloudMachineItem->updateInfoAsync(false /* delayed? */);
+        else
+            pCloudMachineItem->waitForAsyncInfoUpdateFinished();
+    }
+}
+
 void UIChooserItemMachine::startEditing()
 {

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItemMachine.h

@@ -105 +105 @@
         /** Returns RTTI item type. */
         virtual int type() const /* override */ { return Type; }
+
+        /** Defines item as @a fSelected. */
+        virtual void setSelected(bool fSelected) /* override */;
 
         /** Starts item editing. */