Changeset 86787 in vbox for trunk/src/VBox/Frontends

Timestamp:

Nov 2, 2020 6:21:59 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Chooser pane: Move some refresh stuff to separate place to make it reusable.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser

Files:

• UIChooserAbstractModel.cpp (modified) (2 diffs)
• UIChooserAbstractModel.h (modified) (1 diff)
• UIChooserModel.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserAbstractModel.cpp

@@ -913 +913 @@
     /* Reload cloud tree: */
     reloadCloudTree();
+}
+
+void UIChooserAbstractModel::createReadCloudMachineListTask(const UICloudEntityKey &guiCloudProfileKey, bool fWithRefresh)
+{
+    /* Create list cloud machines task: */
+    UITaskCloudListMachines *pTask = new UITaskCloudListMachines(guiCloudProfileKey.m_strProviderShortName,
+                                                                 guiCloudProfileKey.m_strProfileName,
+                                                                 fWithRefresh);
+    AssertPtrReturnVoid(pTask);
+    uiCommon().threadPoolCloud()->enqueueTask(pTask);
 }
 
@@ -1116 +1126 @@
 
             /* Create list cloud machines task: */
-            UITaskCloudListMachines *pTask = new UITaskCloudListMachines(strProviderShortName,
-                                                                         strProfileName,
-                                                                         true /* with refresh? */);
-            AssertPtrReturnVoid(pTask);
-            uiCommon().threadPoolCloud()->enqueueTask(pTask);
+            createReadCloudMachineListTask(guiCloudProfileKey, true /* with refresh? */);
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserAbstractModel.h

@@ -222 +222 @@
     /** @} */
 
+protected:
+
+    /** @name Children stuff.
+      * @{ */
+        /** Creates and registers read cloud machine list task with @a guiCloudProfileKey.
+          * @param  fWithRefresh  Brings whether machines should be refreshed as well. */
+        void createReadCloudMachineListTask(const UICloudEntityKey &guiCloudProfileKey, bool fWithRefresh);
+    /** @} */
+
 private slots:
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp

@@ -945 +945 @@
 
                 /* Create list cloud machines task: */
-                UITaskCloudListMachines *pTask = new UITaskCloudListMachines(guiCloudProfileKey.m_strProviderShortName,
-                                                                             guiCloudProfileKey.m_strProfileName,
-                                                                             true /* with refresh? */);
-                AssertPtrReturnVoid(pTask);
-                uiCommon().threadPoolCloud()->enqueueTask(pTask);
+                createReadCloudMachineListTask(guiCloudProfileKey, true /* with refresh? */);
 
                 break;
@@ -1368 +1364 @@
 
         /* Create a task for particular cloud entity key: */
-        UITaskCloudListMachines *pTask = new UITaskCloudListMachines(guiCloudProfileKey.m_strProviderShortName,
-                                                                     guiCloudProfileKey.m_strProfileName,
-                                                                     false /* with refresh? */);
-        AssertPtrReturnVoid(pTask);
-        uiCommon().threadPoolCloud()->enqueueTask(pTask);
+        createReadCloudMachineListTask(guiCloudProfileKey, false /* with refresh? */);
     }
 }
@@ -1967 +1959 @@
 
         /* Create a task for particular cloud entity key: */
-        UITaskCloudListMachines *pTask = new UITaskCloudListMachines(guiCloudProfileKey.m_strProviderShortName,
-                                                                     guiCloudProfileKey.m_strProfileName,
-                                                                     false /* with refresh? */);
-        AssertPtrReturnVoid(pTask);
-        uiCommon().threadPoolCloud()->enqueueTask(pTask);
+        createReadCloudMachineListTask(guiCloudProfileKey, false /* with refresh? */);
     }
 }