Changeset 86869 in vbox for trunk/src

Timestamp:

Nov 12, 2020 7:59:52 AM (4 years ago)

Author:

vboxsync

Message:

DnD: Termination fixes / clarification.

Location:

trunk/src/VBox

Files:

• Additions/WINNT/VBoxTray/VBoxDnD.cpp (modified) (2 diffs)
• Additions/common/VBoxGuest/lib/VBoxGuestR3LibDragAndDrop.cpp (modified) (4 diffs)
• HostServices/DragAndDrop/VBoxDragAndDropSvc.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDnD.cpp

@@ -610 +610 @@
                 }
 
+                case VBGLR3DNDEVENTTYPE_QUIT:
+                {
+                    LogRel(("DnD: Received quit message, shutting down ...\n"));
+                    PostQuitMessage(0);
+                }
+
 #ifdef VBOX_WITH_DRAG_AND_DROP_GH
                 case VBGLR3DNDEVENTTYPE_GH_ERROR:
@@ -1877 +1883 @@
                 LogRel(("DnD: Processing proxy window event %RU32 failed with %Rrc\n", pVbglR3Event->enmType, rc));
         }
-        else if (rc == VERR_INTERRUPTED) /* Disconnected from service. */
-        {
-            LogRel(("DnD: Received quit message, shutting down ...\n"));
-            pWnd->PostMessage(WM_QUIT, 0 /* wParm */, 0 /* lParm */);
-            rc = VINF_SUCCESS;
-        }
 
         if (RT_FAILURE(rc))

trunk/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR3LibDragAndDrop.cpp

@@ -61 +61 @@
  *
  * @returns IPRT status code.
+ *          Will return VERR_CANCELLED (implemented by the host service) if we need to bail out.
  * @param   pCtx                DnD context to use.
  * @param   puMsg               Where to store the message type.
@@ -72 +73 @@
     AssertPtrReturn(pcParms, VERR_INVALID_POINTER);
 
-    HGCMMsgGetNext Msg;
-    VBGL_HGCM_HDR_INIT(&Msg.hdr, pCtx->uClientID, GUEST_DND_FN_GET_NEXT_HOST_MSG, 3);
-    Msg.uMsg.SetUInt32(0);
-    Msg.cParms.SetUInt32(0);
-    Msg.fBlock.SetUInt32(fWait ? 1 : 0);
-
-    int rc = VbglR3HGCMCall(&Msg.hdr, sizeof(Msg));
-    if (RT_SUCCESS(rc))
-    {
-        rc = Msg.uMsg.GetUInt32(puMsg);     AssertRC(rc);
-        rc = Msg.cParms.GetUInt32(pcParms); AssertRC(rc);
-    }
+    int rc;
+
+    do
+    {
+        HGCMMsgGetNext Msg;
+        VBGL_HGCM_HDR_INIT(&Msg.hdr, pCtx->uClientID, GUEST_DND_FN_GET_NEXT_HOST_MSG, 3);
+        Msg.uMsg.SetUInt32(0);
+        Msg.cParms.SetUInt32(0);
+        Msg.fBlock.SetUInt32(fWait ? 1 : 0);
+
+        rc = VbglR3HGCMCall(&Msg.hdr, sizeof(Msg));
+        if (RT_SUCCESS(rc))
+        {
+            rc = Msg.uMsg.GetUInt32(puMsg);     AssertRC(rc);
+            rc = Msg.cParms.GetUInt32(pcParms); AssertRC(rc);
+        }
+
+    } while (rc == VERR_INTERRUPTED);
 
     return rc;
@@ -1078 +1085 @@
 {
     AssertPtrReturn(pCtx, VERR_INVALID_POINTER);
+
+    if (!pCtx->uClientID) /* Already disconnected? Bail out early. */
+        return VINF_SUCCESS;
+
     int rc = VbglR3HGCMDisconnect(pCtx->uClientID);
     if (RT_SUCCESS(rc))
         pCtx->uClientID = 0;
+
     return rc;
 }
@@ -1162 +1174 @@
                 rc = VbglR3DnDConnect(pCtx);
         }
+    }
+
+    if (rc == VERR_CANCELLED) /* Host service told us that we have to bail out. */
+    {
+        pEvent->enmType = VBGLR3DNDEVENTTYPE_QUIT;
+
+        *ppEvent = pEvent;
+
+        return VINF_SUCCESS;
     }
 

trunk/src/VBox/HostServices/DragAndDrop/VBoxDragAndDropSvc.cpp

@@ -147 +147 @@
 void DragAndDropClient::disconnect(void) RT_NOEXCEPT
 {
-    LogFlowThisFunc(("uClient=%RU32\n", m_idClient));
-
+    LogFlowThisFunc(("uClient=%RU32, fDeferred=%RTbool\n", m_idClient, IsDeferred()));
+
+    /*
+     * If the client still is waiting for a message (i.e in deferred mode),
+     * complete the call with a VERR_CANCELED status so that the client (VBoxTray / VBoxClient) knows
+     * it should bail out.
+     */
     if (IsDeferred())
-        CompleteDeferred(VERR_INTERRUPTED);
+        CompleteDeferred(VERR_CANCELLED);
 
     /*
@@ -471 +476 @@
             break;
     }
-
-#ifdef DEBUG_andy
-    LogFlowFunc(("Mode (%RU32) check rc=%Rrc\n", modeGet(), rc));
-#endif
 
 #define DO_HOST_CALLBACK();                                                                   \
@@ -1028 +1029 @@
     if (rc == VINF_HGCM_ASYNC_EXECUTE)
     {
+        LogFlowFunc(("Deferring client %RU32\n", idClient));
+
         try
         {