Changeset 87264 in vbox for trunk/src

Timestamp:

Jan 15, 2021 11:16:46 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142223

Message:

Audio/HDA: Resolved a @todo.

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -1584 +1584 @@
     }
 
-    if (u32FIFOW) /** @todo r=bird: Logic error. it will never be zero, so why this check? */
-    {
-        pThis->aStreams[idxStream].u16FIFOW = hdaSDFIFOWToBytes(u32FIFOW);
-        LogFunc(("[SD%zu] Updating FIFOW to %u bytes\n", idxStream, pThis->aStreams[idxStream].u16FIFOW));
-        return hdaRegWriteU16(pDevIns, pThis, iReg, u32FIFOW);
-    }
-    return VINF_SUCCESS;
+    pThis->aStreams[idxStream].u16FIFOW = hdaSDFIFOWToBytes(u32FIFOW);
+    LogFunc(("[SD%zu] Updating FIFOW to %u bytes\n", idxStream, pThis->aStreams[idxStream].u16FIFOW));
+    return hdaRegWriteU16(pDevIns, pThis, iReg, u32FIFOW);
 }