Changeset 87293 in vbox

Timestamp:

Jan 18, 2021 8:36:08 AM (4 years ago)

Author:

vboxsync

Message:

AMD IOMMU: bugref:9654 Add profiling stat for device table lookups (uncached).

File:

• trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -327 +327 @@
     STAMCOUNTER             StatCmdCompletePprReq;      /**< Number of Complete PPR Requests commands processed. */
     STAMCOUNTER             StatCmdInvIommuAll;         /**< Number of Invalidate IOMMU All commands processed. */
+
+    STAMPROFILEADV          StatDteLookup;              /**< Profiling of device table entry lookup (uncached). */
     /** @} */
 #endif
@@ -2650 +2652 @@
 {
     PIOMMU pThis = PDMDEVINS_2_DATA(pDevIns, PIOMMU);
+    STAM_PROFILE_ADV_START(&pThis->StatDteLookup, a);
 
     /* Read the device table entry from memory. */
@@ -2663 +2666 @@
             /** @todo IOMMU: Add to IOLTB cache. */
             *pGCPhysSpa = uIova;
+            STAM_PROFILE_ADV_STOP(&pThis->StatDteLookup, a);
             return VINF_SUCCESS;
         }
@@ -2678 +2682 @@
             iommuAmdInitIllegalDteEvent(uDevId, uIova, true /* fRsvdNotZero */, enmOp, &Event);
             iommuAmdRaiseIllegalDteEvent(pDevIns, enmOp, &Event, kIllegalDteType_RsvdNotZero);
+            STAM_PROFILE_ADV_STOP(&pThis->StatDteLookup, a);
             return VERR_IOMMU_ADDR_TRANSLATION_FAILED;
         }
@@ -2689 +2694 @@
             /** @todo IOMMU: Add to IOLTB cache. */
             *pGCPhysSpa = uIova;
+            STAM_PROFILE_ADV_STOP(&pThis->StatDteLookup, a);
             return VINF_SUCCESS;
         }
@@ -2739 +2745 @@
                      uBaseIova, fAccess, rc));
                 *pGCPhysSpa = NIL_RTGCPHYS;
+                STAM_PROFILE_ADV_STOP(&pThis->StatDteLookup, a);
                 return rc;
             }
         }
 
+        STAM_PROFILE_ADV_STOP(&pThis->StatDteLookup, a);
         return rc;
     }
 
     LogFunc(("Failed to read device table entry. uDevId=%#x rc=%Rrc\n", uDevId, rc));
+    STAM_PROFILE_ADV_STOP(&pThis->StatDteLookup, a);
     return VERR_IOMMU_ADDR_TRANSLATION_FAILED;
 }
@@ -4732 +4741 @@
     PDMDevHlpSTAMRegister(pDevIns, &pThis->StatCmdCompletePprReq, STAMTYPE_COUNTER, "R3/Commands/CompletePprReq", STAMUNIT_OCCURENCES, "Number of Complete PPR Requests commands processed.");
     PDMDevHlpSTAMRegister(pDevIns, &pThis->StatCmdInvIommuAll, STAMTYPE_COUNTER, "R3/Commands/InvIommuAll", STAMUNIT_OCCURENCES, "Number of Invalidate IOMMU All commands processed.");
+
+    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatDteLookup, STAMTYPE_PROFILE, "DteLookup", STAMUNIT_TICKS_PER_CALL, "Profiling device table entry lookup (uncached).");
 # endif