Changeset 87462 in vbox for trunk/src/VBox/VMM/VMMR0

Timestamp:

Jan 28, 2021 2:45:14 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142481

Message:

VMM/HMVMX: Just pass NULL instead of pVM to pfnStartVm as it doesn't use it.

Location:

trunk/src/VBox/VMM/VMMR0

Files:

• HMR0A.asm (modified) (1 diff)
• HMVMXR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HMR0A.asm

@@ -699 +699 @@
 ;
 ; @returns VBox status code
-; @param    pVM        msc:rcx, gcc:rdi       The cross context VM structure. (unused)
+; @param    NULL       msc:rcx, gcc:rdi       The cross context VM structure. (unused, passing NULL now)
 ; @param    pVCpu      msc:rdx, gcc:rsi       The cross context virtual CPU structure of the calling EMT.
 ; @param    fResume    msc:r8l, gcc:dl        Whether to use vmlauch/vmresume.

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -6846 +6846 @@
 {
     /* Mark that HM is the keeper of all guest-CPU registers now that we're going to execute guest code. */
-    PCPUMCTX pCtx = &pVCpu->cpum.GstCtx;
-    pCtx->fExtrn |= HMVMX_CPUMCTX_EXTRN_ALL | CPUMCTX_EXTRN_KEEPER_HM;
+    pVCpu->cpum.GstCtx.fExtrn |= HMVMX_CPUMCTX_EXTRN_ALL | CPUMCTX_EXTRN_KEEPER_HM;
 
     /** @todo Add stats for VMRESUME vs VMLAUNCH. */
-
-    /*
-     * 64-bit Windows uses XMM registers in the kernel as the Microsoft compiler expresses
-     * floating-point operations using SSE instructions. Some XMM registers (XMM6-XMM15) are
-     * callee-saved and thus the need for this XMM wrapper.
-     *
-     * See MSDN "Configuring Programs for 64-bit/x64 Software Conventions / Register Usage".
-     */
     bool const fResumeVM = RT_BOOL(pVmxTransient->pVmcsInfo->fVmcsState & VMX_V_VMCS_LAUNCH_STATE_LAUNCHED);
-    PVMCC pVM = pVCpu->CTX_SUFF(pVM);
-    int rc = pVCpu->hm.s.vmx.pfnStartVm(pVM, pVCpu, fResumeVM);
+    int rc = pVCpu->hm.s.vmx.pfnStartVm(NULL /*pVCpu->CTX_SUFF(pVM) - unused*/, pVCpu, fResumeVM);
     AssertMsg(rc <= VINF_SUCCESS, ("%Rrc\n", rc));
     return rc;