Changeset 87494 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Feb 1, 2021 5:47:40 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142518

Message:

AMD IOMMU: bugref:9654 PDM IOMMU code de-duplication and cleanup, part 3.

File:

• trunk/src/VBox/VMM/VMMAll/PDMAllIommu.cpp (modified) (10 diffs)

trunk/src/VBox/VMM/VMMAll/PDMAllIommu.cpp

@@ -63 +63 @@
 #endif
     return PCIBDF_MAKE(pBus->iBus, pPciDev->uDevFn);
+}
+
+
+/** @copydoc PDMIOMMUREGR3::pfnMsiRemap */
+int pdmIommuMsiRemap(PPDMDEVINS pDevIns, uint16_t uDeviceId, PCMSIMSG pMsiIn, PMSIMSG pMsiOut)
+{
+    PPDMIOMMU  pIommu       = PDMDEVINS_TO_IOMMU(pDevIns);
+    PPDMDEVINS pDevInsIommu = pIommu->CTX_SUFF(pDevIns);
+    if (   pDevInsIommu
+        && pDevInsIommu != pDevIns)
+    {
+        int rc = pIommu->pfnMsiRemap(pDevInsIommu, uDeviceId, pMsiIn, pMsiOut);
+        if (RT_FAILURE(rc))
+        {
+            LogFunc(("MSI remap failed. uDeviceId=%#x pMsiIn=(%#RX64, %#RU32) rc=%Rrc\n", uDeviceId, pMsiIn->Addr.u64,
+                     pMsiIn->Data.u32, rc));
+        }
+        return rc;
+    }
+    return VERR_IOMMU_NOT_PRESENT;
 }
 
@@ -178 +198 @@
 
 
+#ifdef IN_RING3
 /**
  * Requests the mapping of a guest page into ring-3 in preparation for a bus master
@@ -196 +217 @@
  *                      pfnPhysReleasePageMappingLock needs.
  */
-int pdmIommuMemAccessReadCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, RTGCPHYS GCPhys, uint32_t fFlags, void const **ppv,
-                               PPGMPAGEMAPLOCK pLock)
-{
-#if defined(IN_RING3)
+int pdmR3IommuMemAccessReadCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, RTGCPHYS GCPhys, uint32_t fFlags, void const **ppv,
+                                 PPGMPAGEMAPLOCK pLock)
+{
     PPDMIOMMU  pIommu       = PDMDEVINS_TO_IOMMU(pDevIns);
     PPDMDEVINS pDevInsIommu = pIommu->CTX_SUFF(pDevIns);
@@ -221 +241 @@
     }
     return VERR_IOMMU_NOT_PRESENT;
-#else
-    RT_NOREF6(pDevIns, pPciDev, GCPhys, fFlags, ppv, pLock);
-    return VERR_NOT_IMPLEMENTED;
-#endif
 }
 
@@ -246 +262 @@
  *                      pfnPhysReleasePageMappingLock needs.
  */
-int pdmIommuMemAccessWriteCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, RTGCPHYS GCPhys, uint32_t fFlags, void **ppv,
-                                PPGMPAGEMAPLOCK pLock)
-{
-#if defined(IN_RING3)
+int pdmR3IommuMemAccessWriteCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, RTGCPHYS GCPhys, uint32_t fFlags, void **ppv,
+                                  PPGMPAGEMAPLOCK pLock)
+{
     PPDMIOMMU  pIommu       = PDMDEVINS_TO_IOMMU(pDevIns);
     PPDMDEVINS pDevInsIommu = pIommu->CTX_SUFF(pDevIns);
@@ -271 +286 @@
     }
     return VERR_IOMMU_NOT_PRESENT;
-#else
-    RT_NOREF6(pDevIns, pPciDev, GCPhys, fFlags, ppv, pLock);
-    return VERR_NOT_IMPLEMENTED;
-#endif
 }
 
@@ -299 +310 @@
  *                              in length).
  */
-int pdmIommuMemAccessBulkReadCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, uint32_t cPages, PCRTGCPHYS paGCPhysPages,
-                                   uint32_t fFlags, const void **papvPages, PPGMPAGEMAPLOCK paLocks)
-{
-#ifdef IN_RING3
+int pdmR3IommuMemAccessBulkReadCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, uint32_t cPages, PCRTGCPHYS paGCPhysPages,
+                                     uint32_t fFlags, const void **papvPages, PPGMPAGEMAPLOCK paLocks)
+{
     PPDMIOMMU  pIommu       = PDMDEVINS_TO_IOMMU(pDevIns);
     PPDMDEVINS pDevInsIommu = pIommu->CTX_SUFF(pDevIns);
@@ -339 +349 @@
     }
     return VERR_IOMMU_NOT_PRESENT;
-#else
-    RT_NOREF7(pDevIns, pPciDev, cPages, paGCPhysPages, fFlags, papvPages, paLocks);
-    return VERR_NOT_IMPLEMENTED;
-#endif
 }
 
@@ -367 +373 @@
  *                              in length).
  */
-int pdmIommuMemAccessBulkWriteCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, uint32_t cPages, PCRTGCPHYS paGCPhysPages,
-                                    uint32_t fFlags, void **papvPages, PPGMPAGEMAPLOCK paLocks)
-{
-#ifdef IN_RING3
+int pdmR3IommuMemAccessBulkWriteCCPtr(PPDMDEVINS pDevIns, PPDMPCIDEV pPciDev, uint32_t cPages, PCRTGCPHYS paGCPhysPages,
+                                      uint32_t fFlags, void **papvPages, PPGMPAGEMAPLOCK paLocks)
+{
     PPDMIOMMU  pIommu       = PDMDEVINS_TO_IOMMU(pDevIns);
     PPDMDEVINS pDevInsIommu = pIommu->CTX_SUFF(pDevIns);
@@ -407 +412 @@
     }
     return VERR_IOMMU_NOT_PRESENT;
-#else
-    RT_NOREF7(pDevIns, pPciDev, cPages, paGCPhysPages, fFlags, papvPages, paLocks);
-    return VERR_NOT_IMPLEMENTED;
-#endif
-}
-
-
-/** @copydoc PDMIOMMUREGR3::pfnMsiRemap */
-int pdmIommuMsiRemap(PPDMDEVINS pDevIns, uint16_t uDeviceId, PCMSIMSG pMsiIn, PMSIMSG pMsiOut)
-{
-    PPDMIOMMU  pIommu       = PDMDEVINS_TO_IOMMU(pDevIns);
-    PPDMDEVINS pDevInsIommu = pIommu->CTX_SUFF(pDevIns);
-    if (   pDevInsIommu
-        && pDevInsIommu != pDevIns)
-    {
-        int rc = pIommu->pfnMsiRemap(pDevInsIommu, uDeviceId, pMsiIn, pMsiOut);
-        if (RT_FAILURE(rc))
-        {
-            LogFunc(("MSI remap failed. uDeviceId=%#x pMsiIn=(%#RX64, %#RU32) rc=%Rrc\n", uDeviceId, pMsiIn->Addr.u64,
-                     pMsiIn->Data.u32, rc));
-        }
-        return rc;
-    }
-    return VERR_IOMMU_NOT_PRESENT;
-}
-
+}
+#endif /* IN_RING3 */
+