Changeset 87533 in vbox

Timestamp:

Feb 2, 2021 12:02:29 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9927: VM settings / Storage page: While changing a set of bus/type simultaneously we need to assign initial set together instead of acquiring type value after bus changed, else values could be desynchronized.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -3872 +3872 @@
             else if (pSender == m_pComboType)
             {
+                const KStorageBus enmBus = m_pComboType->currentData(StorageModel::R_CtrBusType).value<KStorageBus>();
+                const KStorageControllerType enmType = m_pComboType->currentData(StorageModel::R_CtrType).value<KStorageControllerType>();
                 const bool fResult =
-                    m_pModelStorage->setData(index,
-                                             QVariant::fromValue(m_pComboType->currentData(StorageModel::R_CtrBusType).value<KStorageBus>()),
-                                             StorageModel::R_CtrBusType);
+                    m_pModelStorage->setData(index, QVariant::fromValue(enmBus), StorageModel::R_CtrBusType);
                 if (fResult)
-                    m_pModelStorage->setData(index,
-                                             QVariant::fromValue(m_pComboType->currentData(StorageModel::R_CtrType).value<KStorageControllerType>()),
-                                             StorageModel::R_CtrType);
+                    m_pModelStorage->setData(index, QVariant::fromValue(enmType), StorageModel::R_CtrType);
             }
             else if (pSender == m_pSpinboxPortCount)