Changeset 87587 in vbox

Timestamp:

Feb 3, 2021 4:46:12 PM (4 years ago)

Author:

vboxsync

Message:

Audio/HDA: Re-applied r142615 as intended: More timing-related fixes for Windows guests. This is a risky change and needs more testing / verification on other guests. Only got limited testing for Win10 AU / Win10 20H2 and Ubuntu 20.10 guests so far [build fix]. ticketoem2ref:36

File:

• trunk/src/VBox/Devices/Audio/HDAStream.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/HDAStream.cpp

@@ -29 +29 @@
 #include <VBox/vmm/pdmdev.h>
 #include <VBox/vmm/pdmaudioifs.h>
-
-#include <math.h> /* Needed for roundl(). */
 
 #include "DrvAudio.h"
@@ -548 +546 @@
                 const double cTicksPerByte = cTicksPerHz / (double)pStreamShared->State.cbTransferChunk;
 
+#define HDA_ROUND_NEAREST(a_X) ((a_X) >= 0 ? (uint32_t)((a_X) + 0.5) : (uint32_t)((a_X) - 0.5)) /** @todo r=andy Do we have rounding in IPRT? */
+
                 /* Calculate the timer ticks per byte for this stream. */
-                pStreamShared->State.cTicksPerByte = roundl(cTicksPerByte); /** @todo r=andy Do we have rounding in IPRT? */
+                pStreamShared->State.cTicksPerByte = HDA_ROUND_NEAREST(cTicksPerByte);
                 Assert(pStreamShared->State.cTicksPerByte);
 
@@ -555 +555 @@
 
                 /* Calculate timer ticks per transfer. */
-                pStreamShared->State.cTransferTicks = roundl(cTransferTicks);
+                pStreamShared->State.cTransferTicks = HDA_ROUND_NEAREST(cTransferTicks);
                 Assert(pStreamShared->State.cTransferTicks);
+
+#undef HDA_ROUND_NEAREST
 
                 LogRel2(("HDA: Stream #%RU8 is using %uHz device timer (%RU64 virtual ticks / Hz), stream Hz=%RU32, "
@@ -2110 +2112 @@
 
 #endif /* IN_RING3 */
-