Changeset 87597 in vbox for trunk/src/VBox/VMM

Timestamp:

Feb 4, 2021 12:05:03 AM (4 years ago)

Author:

vboxsync

Message:

VMM/DBGF: Eliminated some unnecessary variable initializations. (Some of the compiler will certainly tell you if you forget to initialize "rc" or any other variable, where-as it both looks totally wrong (to me at least) to assign a value to a variable which you do not use and you also risk not assigning it the correct value in some code path.) bugref:9837

File:

• trunk/src/VBox/VMM/VMMR3/DBGFR3Bp.cpp (modified) (6 diffs)

trunk/src/VBox/VMM/VMMR3/DBGFR3Bp.cpp

@@ -1330 +1330 @@
     {
         uint32_t u32Entry = ASMAtomicReadU32(&pUVM->dbgf.s.paBpLocL1R3[idxL1]);
-
         if (u32Entry == DBGF_BP_INT3_L1_ENTRY_TYPE_NULL)
         {
@@ -1344 +1343 @@
         {
             rc = dbgfR3BpInt3L2BstNodeAdd(pUVM, idxL1, hBp, pBp->Pub.u.Int3.GCPtr);
-            if (rc == VINF_TRY_AGAIN)
-                continue;
-
-            break;
+            if (rc != VINF_TRY_AGAIN)
+                break;
         }
     }
@@ -1563 +1560 @@
 static int dbgfR3BpArm(PUVM pUVM, DBGFBP hBp, PDBGFBPINT pBp)
 {
-    int rc = VINF_SUCCESS;
+    int rc;
     PVM pVM = pUVM->pVM;
 
@@ -1637 +1634 @@
 static int dbgfR3BpDisarm(PUVM pUVM, DBGFBP hBp, PDBGFBPINT pBp)
 {
-    int rc = VINF_SUCCESS;
+    int rc;
     PVM pVM = pUVM->pVM;
 
@@ -2229 +2226 @@
     AssertPtrReturn(pBp, VERR_DBGF_BP_NOT_FOUND);
 
-    int rc = VINF_SUCCESS;
+    int rc;
     if (!DBGF_BP_PUB_IS_ENABLED(pBp->Pub.fFlagsAndType))
         rc = dbgfR3BpArm(pUVM, hBp, pBp);
@@ -2259 +2256 @@
     AssertPtrReturn(pBp, VERR_DBGF_BP_NOT_FOUND);
 
-    int rc = VINF_SUCCESS;
+    int rc;
     if (DBGF_BP_PUB_IS_ENABLED(pBp->Pub.fFlagsAndType))
         rc = dbgfR3BpDisarm(pUVM, hBp, pBp);