Changeset 87625 in vbox for trunk/src/VBox/VMM

Timestamp:

Feb 5, 2021 12:58:09 PM (4 years ago)

Author:

vboxsync

Message:

VMM/HMVMX: Time todos.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -5117 +5117 @@
              * For nested-guests, currently not exposed/used.
              */
+            /** @todo r=bird: Measure performance hit because of this vs. always rewriting
+             *        the timer value. */
             if (pVM->hmr0.s.vmx.fUsePreemptTimer)
             {
@@ -7129 +7131 @@
         /* Make sure the returned values have sane upper and lower boundaries. */
         uint64_t u64CpuHz  = SUPGetCpuHzFromGipBySetIndex(g_pSUPGlobalInfoPage, pVCpu->iHostCpuSet);
-        cTicksToDeadline   = RT_MIN(cTicksToDeadline, u64CpuHz / 64);      /* 1/64th of a second */
+        cTicksToDeadline   = RT_MIN(cTicksToDeadline, u64CpuHz / 64);      /* 1/64th of a second */ /** @todo r=bird: Once real+virtual timers move to separate thread, we can raise the upper limit (16ms isn't much). ASSUMES working poke cpu function. */
         cTicksToDeadline   = RT_MAX(cTicksToDeadline, u64CpuHz / 2048);    /* 1/2048th of a second */
         cTicksToDeadline >>= pVM->hm.s.vmx.cPreemptTimerShift;