Changeset 87713 in vbox for trunk/src/VBox/Devices

Timestamp:

Feb 11, 2021 6:27:01 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142757

Message:

AMD IOMMU: bugref:9654 IOTLB cache bits.

File:

• trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -53 +53 @@
 # define IOMMU_DTE_CACHE_MAX                        UINT16_MAX
 /** The maximum number of IOTLB entries. */
-# define IOMMU_IOTLBE_MAX                           128
+# define IOMMU_IOTLBE_MAX                           96
 /** The mask of bits covering the domain ID in the IOTLBE key. */
 # define IOMMU_IOTLB_DOMAIN_ID_MASK                 UINT64_C(0xffffff0000000000)
@@ -902 +902 @@
 
 /**
- * Destroys an IOTLB entry.
- *
- * @param   pIotlbe     The IOTLB entry to destroy.
- * @remarks An entry must only be destroyed if it's not in the cache!
- */
-static void iommuAmdIotlbEntryDestroy(PIOTLBE pIotlbe)
-{
-    /* We must not erase the LRU node connections here! */
-    RT_ZERO(pIotlbe->Core);
-    RT_ZERO(pIotlbe->WalkResult);
-    pIotlbe->fEvictPending = false;
-    Assert(pIotlbe->Core.Key == IOMMU_IOTLB_KEY_NIL);
-}
-
-
-/**
  * Removes an IOTLB entry from the cache for the given key.
  *
@@ -932 +916 @@
         if (pIotlbe->fEvictPending)
             STAM_COUNTER_INC(&pThis->StatIotlbeLazyEvictReuse);
-        iommuAmdIotlbEntryDestroy(pIotlbe);
-        Assert(!pIotlbe->fEvictPending);
+
+        RT_ZERO(pIotlbe->Core);
+        RT_ZERO(pIotlbe->WalkResult);
+        /* We must not erase the LRU node connections here! */
+        pIotlbe->fEvictPending = false;
+        Assert(pIotlbe->Core.Key == IOMMU_IOTLB_KEY_NIL);
+
         Assert(pThis->cCachedIotlbes > 0);
         --pThis->cCachedIotlbes;