Changeset 87733 in vbox for trunk/src/VBox

Timestamp:

Feb 12, 2021 1:40:48 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142785

Message:

AMD IOMMU: bugref:9654 PREFETCH_IOMMU_PAGES comment and nit.

File:

• trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -4535 +4535 @@
         case IOMMU_CMD_PREFETCH_IOMMU_PAGES:
         {
+            /* Linux doesn't use prefetching of IOMMU pages, so we don't bother for now. */
             STAM_COUNTER_INC(&pThis->StatCmdPrefIommuPages);
-            if (pThis->ExtFeat.n.u1PrefetchSup)
-            {
-                /** @todo IOMMU: Implement prefetch. Pretend success until then. */
-                return VINF_SUCCESS;
-            }
+            Assert(!pThis->ExtFeat.n.u1PrefetchSup);
             iommuAmdIllegalCmdEventInit(GCPhysCmd, (PEVT_ILLEGAL_CMD_ERR_T)pEvtError);
             return VERR_IOMMU_CMD_NOT_SUPPORTED;
@@ -4996 +4993 @@
         if (fVerbose)
         {
-            pHlp->pfnPrintf(pHlp, "    Prefetch support                        = %RTbool\n", ExtFeat.n.u1PrefetchSup);
+            pHlp->pfnPrintf(pHlp, "    Prefetch support                        = %RTbool\n",  ExtFeat.n.u1PrefetchSup);
             pHlp->pfnPrintf(pHlp, "    PPR support                             = %RTbool\n",  ExtFeat.n.u1PprSup);
             pHlp->pfnPrintf(pHlp, "    x2APIC support                          = %RTbool\n",  ExtFeat.n.u1X2ApicSup);
@@ -6089 +6086 @@
     /* Don't remove the commented lines below as it lets us see all features at a glance. */
     pThis->ExtFeat.u64 = 0;
-    //pThis->ExtFeat.n.u1PrefetchSup           = 0;
+    pThis->ExtFeat.n.u1PrefetchSup             = 0;
     //pThis->ExtFeat.n.u1PprSup                = 0;
     //pThis->ExtFeat.n.u1X2ApicSup             = 0;