Changeset 87736 in vbox for trunk/src/VBox/Frontends

Timestamp:

Feb 12, 2021 3:03:35 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142788

Message:

FE/Qt: Working on the error indicators of QILineEdit.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• extensions/QILineEdit.cpp (modified) (2 diffs)
• extensions/QILineEdit.h (modified) (2 diffs)
• settings/editors/UINameAndSystemEditor.cpp (modified) (1 diff)
• widgets/UIUserNamePasswordEditor.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/extensions/QILineEdit.cpp

@@ -64 +64 @@
 }
 
-void QILineEdit::mark(bool fError)
+void QILineEdit::mark(bool fError, const QString &strErrorMessage /* = QString() */)
 {
-    if (fError == m_fMarkForError)
+    if (fError == m_fMarkForError && m_strErrorMessage == strErrorMessage)
         return;
     m_fMarkForError = fError;
+    m_strErrorMessage = strErrorMessage;
     update();
 }
@@ -108 +109 @@
             m_pIconLabel = new QLabel(this);
         m_pIconLabel->setPixmap(m_markIcon.pixmap(windowHandle(), QSize(iIconSize, iIconSize)));
+        m_pIconLabel->setToolTip(m_strErrorMessage);
         m_pIconLabel->move(width() - iIconSize - iIconMargin, iIconMargin);
         m_pIconLabel->show();

trunk/src/VBox/Frontends/VirtualBox/src/extensions/QILineEdit.h

@@ -52 +52 @@
     void setFixedWidthByText(const QString &strText);
 
-    /** Sets the color to some reddish color when @p fError is true. Usually used to indicate some error. */
-    void mark(bool fError);
+    /** Puts an icon to mark some error on the right hand side of the line edit. @p is used as tooltip of the icon. */
+    void mark(bool fError, const QString &strErrorMessage = QString());
 
 protected:
@@ -83 +83 @@
 
     QLabel *m_pIconLabel;
-    QIcon m_markIcon;
-    bool m_fMarkForError;
+    QIcon   m_markIcon;
+    bool    m_fMarkForError;
+    QString m_strErrorMessage;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UINameAndSystemEditor.cpp

@@ -257 +257 @@
 {
     if (m_pNameLineEdit)
-        m_pNameLineEdit->mark(fError);
+        m_pNameLineEdit->mark(fError, tr("Invalid name"));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIUserNamePasswordEditor.cpp

@@ -245 +245 @@
     bool fComplete = (m_pUserNameLineEdit && !m_pUserNameLineEdit->text().isEmpty());
     if (m_pUserNameLineEdit)
-        m_pUserNameLineEdit->mark(!fComplete);
+        m_pUserNameLineEdit->mark(!fComplete, UIUserNamePasswordEditor::tr("Invalid username"));
     return fComplete;
 }