Changeset 8776 in vbox for trunk/src/VBox

Timestamp:

May 12, 2008 9:54:31 AM (17 years ago)

Author:

vboxsync

Message:

HGCM wait for a request completion must be not alertable (Windows guest).

File:

• trunk/src/VBox/Additions/WINNT/VBoxGuest/VBoxGuest.cpp (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/VBoxGuest/VBoxGuest.cpp

@@ -361 +361 @@
     while ((pHeader->fu32Flags & VBOX_HGCM_REQ_DONE) == 0)
     {
-        /* Specifying UserMode so killing the user process will abort the wait. */ 
+        /* Specifying UserMode so killing the user process will abort the wait.
+         * @todo Since VbglGRCancel is not yet implemented, the wait itself must
+         *       be not interruptible. The wait can be interrupted only when the
+         *       calling process is being killed.
+         *       When alertable is TRUE, the wait sometimes ends with STATUS_USER_APC.
+         */ 
         NTSTATUS rc = KeWaitForSingleObject (&pDevExt->keventNotification, Executive,
-                                             UserMode, TRUE, pTimeout
+                                             UserMode,
+                                             FALSE, /* Not Alertable */
+                                             pTimeout
                                             );
         dprintf(("VBoxHGCMCallback: Wait returned %d fu32Flags=%x\n", rc, pHeader->fu32Flags));