Changeset 87789 in vbox

Timestamp:

Feb 18, 2021 3:16:05 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142849

Message:

PCI: Fake BIOS needs to enable I/O decoding for any VGA class device, not just for vendor IDs it happens to like. Fixes yellow bang in Win7 guest for unknown vendor IDs.

File:

• trunk/src/VBox/Devices/Bus/DevPCI.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Bus/DevPCI.cpp

@@ -656 +656 @@
                         {
                             paddr = &pGlobals->uPciBiosMmio;
-                            bool fPrefetch =    (u8ResourceType & ((uint8_t)(PCI_ADDRESS_SPACE_MEM_PREFETCH | PCI_ADDRESS_SPACE_IO)))
-                                             == PCI_ADDRESS_SPACE_MEM_PREFETCH;
-
-                            if (devclass == 0x0300 && (vendor_id == 0x80ee || vendor_id == 0x15ad) && fPrefetch)
+                            if (devclass == 0x0300)
                             {
-                                /* VGA: map frame buffer to default Bochs VBE address */
-                                paddr = &uPciBiosSpecialVRAM;
                                 /*
-                                 * For VBoxVGA must enable I/O decoding, because legacy
-                                 * VGA I/O ports are implicitly decoded by a VGA class
-                                 * device. Not needed for VMSVGA or VBoxSVGA, because
-                                 * they have an explicit I/O BAR.
+                                 * Because legacy VGA I/O ports are implicitly decoded
+                                 * by a VGA class device without needing a BAR, we must
+                                 * enable I/O decoding for such devices.
                                  */
                                 fActiveIORegion = true;
+
+                                if (vendor_id == 0x80ee || vendor_id == 0x15ad)
+                                {
+                                    bool fPrefetch =    (u8ResourceType & ((uint8_t)(PCI_ADDRESS_SPACE_MEM_PREFETCH | PCI_ADDRESS_SPACE_IO)))
+                                                     == PCI_ADDRESS_SPACE_MEM_PREFETCH;
+                                    /* VGA: map frame buffer to default Bochs VBE address. Only
+                                     * needed for legacy guest drivers. */
+                                    if (fPrefetch)
+                                        paddr = &uPciBiosSpecialVRAM;
+                                }
                             }
                         }