Changeset 87809 in vbox

Timestamp:

Feb 19, 2021 4:05:53 PM (4 years ago)

Author:

vboxsync

Message:

HDA: Got rid of the stream period's additional locking; not needed, as it's part of the stream's own lock already. ticketoem2ref:36

Location:

trunk/src/VBox/Devices/Audio

Files:

• DevHDA.cpp (modified) (2 diffs)
• HDAStream.cpp (modified) (3 diffs)
• HDAStreamPeriod.cpp (modified) (1 diff)
• HDAStreamPeriod.h (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -1559 +1559 @@
 
     PHDASTREAMPERIOD pPeriod = &pStreamShared->State.Period;
-    hdaR3StreamPeriodLock(pPeriod);
     if (hdaR3StreamPeriodNeedsInterrupt(pPeriod))
         hdaR3StreamPeriodReleaseInterrupt(pPeriod);
@@ -1575 +1574 @@
             hdaR3StreamPeriodBegin(pPeriod, hdaWalClkGetCurrent(pThis) /* Use current wall clock time */);
     }
-    hdaR3StreamPeriodUnlock(pPeriod); /* Unlock before processing interrupt. */
 
     HDA_PROCESS_INTERRUPT(pDevIns, pThis);

trunk/src/VBox/Devices/Audio/HDAStream.cpp

@@ -1099 +1099 @@
 
     PHDASTREAMPERIOD pPeriod = &pStreamShared->State.Period;
-    hdaR3StreamPeriodLock(pPeriod);
 
     bool fProceed = true;
@@ -1122 +1121 @@
     if (!fProceed)
     {
-        hdaR3StreamPeriodUnlock(pPeriod);
         hdaR3StreamUnlock(pStreamR3);
         return VINF_SUCCESS;
@@ -1583 +1581 @@
     LogFlowFuncLeave();
 
-    hdaR3StreamPeriodUnlock(pPeriod);
     hdaR3StreamUnlock(pStreamR3);
 

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.cpp

@@ -223 +223 @@
 
     Log3Func(("[SD%RU8]\n", pPeriod->u8SD));
-}
-
-/**
- * Locks a stream period for serializing access.
- *
- * @returns IPRT status code (safe to ignore, asserted).
- * @param   pPeriod             Stream period to lock.
- */
-int hdaR3StreamPeriodLock(PHDASTREAMPERIOD pPeriod)
-{
-# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
-    int rc = RTCritSectEnter(&pPeriod->CritSect);
-    AssertRC(rc);
-    return rc;
-# else
-    RT_NOREF(pPeriod);
-    return VINF_SUCCESS;
-# endif
-}
-
-/**
- * Unlocks a formerly locked stream period.
- *
- * @param   pPeriod             Stream period to unlock.
- */
-void hdaR3StreamPeriodUnlock(PHDASTREAMPERIOD pPeriod)
-{
-# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
-    int rc2 = RTCritSectLeave(&pPeriod->CritSect);
-    AssertRC(rc2);
-# else
-    RT_NOREF(pPeriod);
-# endif
 }
 

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.h

@@ -99 +99 @@
 void     hdaR3StreamPeriodPause(PHDASTREAMPERIOD pPeriod);
 void     hdaR3StreamPeriodResume(PHDASTREAMPERIOD pPeriod);
-int      hdaR3StreamPeriodLock(PHDASTREAMPERIOD pPeriod);
-void     hdaR3StreamPeriodUnlock(PHDASTREAMPERIOD pPeriod);
 uint64_t hdaR3StreamPeriodFramesToWalClk(PHDASTREAMPERIOD pPeriod, uint32_t uFrames);
 uint64_t hdaR3StreamPeriodGetAbsEndWalClk(PHDASTREAMPERIOD pPeriod);