Changeset 8781 in vbox for trunk

Timestamp:

May 12, 2008 12:51:19 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

30771

Message:

Windows guest HGCM optimization: use a preallocated timeout variable.

Location:

trunk/src/VBox/Additions/WINNT/VBoxGuest

Files:

• NTLegacy.cpp (modified) (1 diff)
• VBoxGuest.cpp (modified) (4 diffs)
• VBoxGuestPnP.cpp (modified) (1 diff)
• VBoxGuest_Internal.h (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/VBoxGuest/NTLegacy.cpp

@@ -242 +242 @@
         // initialize the event notification semaphore
         KeInitializeEvent(&pDevExt->keventNotification, NotificationEvent, FALSE);
+
+        /* Preallocated constant timeout 250ms for HGCM async waiter. */
+        pDevExt->HGCMWaitTimeout.QuadPart  = 250;
+        pDevExt->HGCMWaitTimeout.QuadPart *= -10000;     /* relative in 100ns units */
     }
 

trunk/src/VBox/Additions/WINNT/VBoxGuest/VBoxGuest.cpp

@@ -343 +343 @@
 {
     PVBOXGUESTDEVEXT pDevExt = (PVBOXGUESTDEVEXT)pvData;
-    PLARGE_INTEGER pTimeout;
 
     dprintf(("VBoxHGCMCallback\n"));
@@ -350 +349 @@
      * call; introduce a timeout to make sure we don't wait indefinitely.
      */
-    pTimeout = (PLARGE_INTEGER)VbglPhysHeapAlloc(sizeof(LARGE_INTEGER));
-    Assert(pTimeout);
-    if (!pTimeout)
-        return;
-        
-    pTimeout->QuadPart  = 250;
-    pTimeout->QuadPart *= -10000;     /* relative in 100ns units */
-
 
     while ((pHeader->fu32Flags & VBOX_HGCM_REQ_DONE) == 0)
@@ -370 +361 @@
                                              UserMode,
                                              FALSE, /* Not Alertable */
-                                             pTimeout
+                                             &pDevExt->HGCMWaitTimeout
                                             );
         dprintf(("VBoxHGCMCallback: Wait returned %d fu32Flags=%x\n", rc, pHeader->fu32Flags));
@@ -385 +376 @@
         dprintf(("VBoxHGCMCallback: fu32Flags = %08X\n", pHeader->fu32Flags));
     }
-    VbglPhysHeapFree(pTimeout);    
     return;
 }

trunk/src/VBox/Additions/WINNT/VBoxGuest/VBoxGuestPnP.cpp

@@ -240 +240 @@
                 KeInitializeEvent(&pDevExt->keventNotification, NotificationEvent, FALSE);
 
+                /* Preallocated constant timeout 250ms for HGCM async waiter. */
+                pDevExt->HGCMWaitTimeout.QuadPart  = 250;
+                pDevExt->HGCMWaitTimeout.QuadPart *= -10000;     /* relative in 100ns units */
+
                 VBoxInitMemBalloon(pDevExt);
 

trunk/src/VBox/Additions/WINNT/VBoxGuest/VBoxGuest_Internal.h

@@ -187 +187 @@
     KEVENT keventNotification;
 
+    LARGE_INTEGER HGCMWaitTimeout;
+
     /* Old Windows session id */
     ULONG   ulOldActiveConsoleId;