Changeset 87810 in vbox for trunk/src/VBox/Devices

Timestamp:

Feb 19, 2021 4:08:22 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

142871

Message:

HDA: Got rid of the stream period's additional locking; not needed, as it's part of the stream's own lock already. ticketoem2ref:36

Location:

trunk/src/VBox/Devices/Audio

Files:

• HDAStreamPeriod.cpp (modified) (2 diffs)
• HDAStreamPeriod.h (modified) (1 diff)

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.cpp

@@ -52 +52 @@
     Assert(!(pPeriod->fStatus & HDASTREAMPERIOD_F_VALID));
 
-# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
-    int rc = RTCritSectInit(&pPeriod->CritSect);
-    AssertRCReturnStmt(rc, pPeriod->fStatus = 0, rc);
-# endif
     pPeriod->fStatus = HDASTREAMPERIOD_F_VALID;
 
@@ -69 +65 @@
 {
     if (pPeriod->fStatus & HDASTREAMPERIOD_F_VALID)
-    {
-# ifdef HDA_STREAM_PERIOD_WITH_LOCKING
-        RTCritSectDelete(&pPeriod->CritSect);
-# endif
         pPeriod->fStatus = HDASTREAMPERIOD_F_NONE;
-    }
 }
 

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.h

@@ -54 +54 @@
 typedef struct HDASTREAMPERIOD
 {
-#ifdef HDA_STREAM_PERIOD_WITH_LOCKING
-    /** Critical section for serializing access.
-     * @todo r=bird: This is not needed.  The stream lock is held the two places
-     *       this critsect is entered. */
-    RTCRITSECT              CritSect;
-#endif
     /** Associated HDA stream descriptor (SD) number. */
     uint8_t                 u8SD;