Changeset 87989 in vbox for trunk/src/VBox/Devices

Timestamp:

Mar 6, 2021 11:19:57 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

143112

Message:

DevHDA: Count DMA over-/underflows. bugref:9890

Location:

trunk/src/VBox/Devices

Files:

• Audio/DevHDA.cpp (modified) (1 diff)
• Audio/HDAStream.cpp (modified) (1 diff)
• Audio/HDAStream.h (modified) (1 diff)
• build/VBoxDD.d (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -5143 +5143 @@
     PDMDevHlpSTAMRegister(pDevIns, &pThis->StatRegWritesBlockedByRun,   STAMTYPE_COUNTER, "RegWritesBlockedByRun",   STAMUNIT_OCCURENCES, "Writes blocked by byte RUN bit.");
 # endif
+
+    for (uint8_t idxStream = 0; idxStream < RT_ELEMENTS(pThisCC->aStreams); idxStream++)
+        if (hdaGetDirFromSD(idxStream) == PDMAUDIODIR_OUT)
+            PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.StatDmaFlowErrors, STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,
+                                   "Number of DMA overflows.",  "Stream%u/DMAOverflows", idxStream);
+        else
+            PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.StatDmaFlowErrors, STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,
+                                   "Number of DMA underflows.", "Stream%u/DMAUnderflows", idxStream);
 
     return VINF_SUCCESS;

trunk/src/VBox/Devices/Audio/HDAStream.cpp

@@ -1194 +1194 @@
         /** @todo account for this or something so we can try get back in sync
          *        later... */
-        LogFlowFunc(("Internal DMA/AIO buffer underflow (%#x, wanted at least %#x)\n", cbToProcessMax, pStreamShared->State.cbTransferSize));
-        /// @todo STAM_REL_COUNTER_INC(&pStreamR3->State.StatDmaUnderflow);
+        LogFlowFunc(("Internal DMA/AIO buffer %s (%#x, wanted at least %#x)\n",
+                     hdaGetDirFromSD(uSD) == PDMAUDIODIR_OUT ? "overflow" : "underflow",
+                     cbToProcessMax, pStreamShared->State.cbTransferSize));
+        STAM_REL_COUNTER_INC(&pStreamR3->State.StatDmaFlowErrors);
+#ifdef VBOX_WITH_DTRACE
+        VBOXDD_HDA_STREAM_DMA_FLOWERROR(uSD, cbToProcessMax, pStreamShared->State.cbTransferSize,
+                                        hdaGetDirFromSD(uSD) == PDMAUDIODIR_OUT ? 1 : 0);
+#endif
     }
 

trunk/src/VBox/Devices/Audio/HDAStream.h

@@ -262 +262 @@
         HDASTREAMSTATEAIO       AIO;
 #endif
+        /** Under/overflow statistics counter.   */
+        STAMCOUNTER             StatDmaFlowErrors;
     } State;
     /** Debug bits. */

trunk/src/VBox/Devices/build/VBoxDD.d

@@ -30 +30 @@
     probe hda__stream__dma__out(uint32_t idxStream, uint32_t cb, uint64_t off);
     probe hda__stream__dma__in(uint32_t idxStream, uint32_t cb, uint64_t off);
+    probe hda__stream__dma__flowerror(uint32_t idxStream, uint32_t cbFree, uint32_t cbPeriod, int32_t fOverflow);
     probe hda__stream__aio__out(uint32_t idxStream, uint32_t cb, uint64_t off);
     probe hda__stream__aio__in(uint32_t idxStream, uint32_t cb, uint64_t off);