Changeset 88131 in vbox

Timestamp:

Mar 16, 2021 9:46:13 AM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9510. Marking non-running vms

File:

• trunk/src/VBox/Frontends/VirtualBox/src/activity/overview/UIVMActivityOverviewWidget.cpp (modified) (10 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/activity/overview/UIVMActivityOverviewWidget.cpp

@@ -223 +223 @@
     bool operator==(const UIActivityOverviewItem& other) const;
     bool isWithGuestAdditions();
+    void resetDebugger();
 
     QUuid         m_VMuid;
@@ -312 +313 @@
     /* Return the state of the machine represented by the item at @rowIndex. */
     KMachineState machineState(int rowIndex) const;
+    void setDefaultViewFont(const QFont &font);
+    void setDefaultViewFontColor(const QColor &color);
 
 private slots:
@@ -342 +345 @@
     bool m_fShouldUpdate;
     UIVMActivityOverviewHostStats m_hostStats;
+    QFont m_defaultViewFont;
+    QColor m_defaultViewFontColor;
     /** Maximum length of string length of data displayed in column. Updated in UIActivityOverviewModel::data(..). */
     mutable QMap<int, int> m_columnDataMaxLength;
@@ -777 +782 @@
     , m_uVMExitTotal(0)
 {
-    m_comSession = uiCommon().openSession(uid, KLockType_Shared);
-    if (!m_comSession.isNull())
-    {
-        CConsole comConsole = m_comSession.GetConsole();
-        if (!comConsole.isNull())
-        {
-            m_comGuest = comConsole.GetGuest();
-            m_comDebugger = comConsole.GetDebugger();
-        }
-    }
+    resetDebugger();
 }
 
@@ -809 +805 @@
 }
 
-// UIActivityOverviewItem::UIActivityOverviewItem(const QUuid &uid)
-//     : m_VMuid(uid)
-//     , m_uCPUGuestLoad(0)
-//     , m_uCPUVMMLoad(0)
-//     , m_uTotalRAM(0)
-//     , m_uUsedRAM(0)
-//     , m_fRAMUsagePercentage(0)
-//     , m_uNetworkDownRate(0)
-//     , m_uNetworkUpRate(0)
-//     , m_uNetworkDownTotal(0)
-//     , m_uNetworkUpTotal(0)
-//     , m_uDiskWriteRate(0)
-//     , m_uDiskReadRate(0)
-//     , m_uDiskWriteTotal(0)
-//     , m_uDiskReadTotal(0)
-//     , m_uVMExitRate(0)
-//     , m_uVMExitTotal(0)
-// {
-// }
+void UIActivityOverviewItem::resetDebugger()
+{
+    m_comSession = uiCommon().openSession(m_VMuid, KLockType_Shared);
+    if (!m_comSession.isNull())
+    {
+        CConsole comConsole = m_comSession.GetConsole();
+        if (!comConsole.isNull())
+        {
+            m_comGuest = comConsole.GetGuest();
+            m_comDebugger = comConsole.GetDebugger();
+        }
+    }
+}
 
 UIActivityOverviewItem::~UIActivityOverviewItem()
@@ -981 +971 @@
 }
 
+void UIActivityOverviewModel::setDefaultViewFont(const QFont &font)
+{
+    m_defaultViewFont = font;
+}
+
+void UIActivityOverviewModel::setDefaultViewFontColor(const QColor &color)
+{
+    m_defaultViewFontColor = color;
+}
+
 QVariant UIActivityOverviewModel::data(const QModelIndex &index, int role) const
 {
-    if (role == Qt::FontRole && machineState(index.row()) != KMachineState_Running)
-    {
-        QFont font;
-        font.setItalic(true);
-        return font;
-
+    if (machineState(index.row()) != KMachineState_Running)
+    {
+        if (role == Qt::FontRole)
+        {
+            QFont font(m_defaultViewFont);
+            font.setItalic(true);
+            return font;
+        }
+        if (role == Qt::ForegroundRole || role == Qt::TextColorRole)
+            return m_defaultViewFontColor.lighter(250);
     }
     if (!index.isValid() || role != Qt::DisplayRole || index.row() >= rowCount())
@@ -1025 +1029 @@
     int iIndex = itemIndex(uId);
     if (iIndex != -1 && iIndex < m_itemList.size())
+    {
         m_itemList[iIndex].m_enmMachineState = state;
+        if (state == KMachineState_Running)
+            m_itemList[iIndex].resetDebugger();
+    }
     //
     // /* Remove the machine in case machine is no longer working. */
@@ -1459 +1467 @@
         m_pTableView->setSortingEnabled(true);
         m_pTableView->sortByColumn(0, Qt::AscendingOrder);
+        /* Store the default font and its color of the table on the view. They are used in ::data(..): */
+        m_pModel->setDefaultViewFont(m_pTableView->font());
+        m_pModel->setDefaultViewFontColor(m_pTableView->palette().color(QPalette::WindowText));
+
         connect(m_pModel, &UIActivityOverviewModel::sigDataUpdate,
                 this, &UIVMActivityOverviewWidget::sltHandleDataUpdate);
@@ -1579 +1591 @@
 void UIVMActivityOverviewWidget::sltHandleTableContextMenuRequest(const QPoint &pos)
 {
-    if (!m_pTableView || !m_pTableView->hasSelection())
+    if (!m_pTableView)
         return;
 
@@ -1592 +1604 @@
 {
     Q_UNUSED(deselected);
-    if (m_pVMActivityMonitorAction)
-        m_pVMActivityMonitorAction->setEnabled(!selected.isEmpty());
+    if (!m_pVMActivityMonitorAction || !m_pModel || !m_pProxyModel)
+        return;
+
+    if (selected.indexes().empty())
+    {
+        m_pVMActivityMonitorAction->setEnabled(false);
+        return;
+    }
+    int iMachineIndex = m_pProxyModel->mapToSource(selected.indexes()[0]).row();
+    if (m_pModel->machineState(iMachineIndex) != KMachineState_Running)
+    {
+        m_pVMActivityMonitorAction->setEnabled(false);
+        return;
+    }
+    m_pVMActivityMonitorAction->setEnabled(true);
 }