Changeset 88156 in vbox for trunk/src/VBox

Timestamp:

Mar 17, 2021 2:29:47 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

143305

Message:

DrvHostPulseAudio.cpp: Fixed bogus pCfgAcq->Backend.cFramesBufferSize assignment in paCreateStreamIn (probably harmless). bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp

@@ -439 +439 @@
 }
 
-
 #ifdef DEBUG
+
 static void paStreamCbReqWrite(pa_stream *pStream, size_t cbLen, void *pvContext)
 {
@@ -506 +506 @@
     Log2Func(("Warning: Hit overflow\n"));
 }
+
 #endif /* DEBUG */
-
 
 static void paStreamCbSuccess(pa_stream *pStream, int fSuccess, void *pvUser)
@@ -876 +876 @@
     pCfgAcq->Props.cChannels   = pStreamPA->SampleSpec.channels;
 
-    pCfgAcq->Backend.cFramesPeriod     = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.fragsize);
-    pCfgAcq->Backend.cFramesBufferSize = pCfgAcq->Backend.cFramesBufferSize;
-    pCfgAcq->Backend.cFramesPreBuffering     = pCfgAcq->Backend.cFramesPeriod;
+    pCfgAcq->Backend.cFramesPeriod       = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.fragsize);
+    pCfgAcq->Backend.cFramesBufferSize   = pCfgAcq->Backend.cFramesPeriod;
+    pCfgAcq->Backend.cFramesPreBuffering = pCfgAcq->Backend.cFramesPeriod;
 
     LogFlowFuncLeaveRC(rc);
@@ -891 +891 @@
                                                            void *pvBuf, uint32_t uBufSize, uint32_t *puRead)
 {
-    RT_NOREF(pvBuf, uBufSize);
     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
     AssertPtrReturn(pvBuf,      VERR_INVALID_POINTER);
-    AssertReturn(uBufSize,         VERR_INVALID_PARAMETER);
+    AssertReturn(uBufSize,      VERR_INVALID_PARAMETER);
     /* pcbRead is optional. */