Changeset 88157 in vbox

Timestamp:

Mar 17, 2021 2:30:31 PM (4 years ago)

Author:

vboxsync

Message:

DrvAudio: Logging fixes. bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (9 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -636 +636 @@
 
     uint64_t msBufferSize = PDMAudioPropsFramesToMilli(&CfgHostAcq.Props, CfgHostAcq.Backend.cFramesBufferSize);
-
     LogRel2(("Audio: Buffer size of stream '%s' is %RU64ms (%RU32 frames)\n",
              pStream->szName, msBufferSize, CfgHostAcq.Backend.cFramesBufferSize));
@@ -1530 +1529 @@
 #endif /* LOG_ENABLED */
 
-    do
+    do /* No, this isn't a loop either. sigh. */
     {
         if (!pThis->pHostDrvAudio)
@@ -3143 +3142 @@
      * All parameters in principle can be changed and returned by the backend via the acquired configuration. */
 
-    char szWhat[64]; /* Log where a value came from. */
-
     /*
      * PCM
@@ -3193 +3190 @@
      * Period size
      */
+    const char *pszWhat = "";
     if (pDrvCfg->uPeriodSizeMs)
     {
         pCfgReq->Backend.cFramesPeriod = PDMAudioPropsMilliToFrames(&pCfgReq->Props, pDrvCfg->uPeriodSizeMs);
-        RTStrPrintf(szWhat, sizeof(szWhat), "custom");
+        pszWhat = "custom";
     }
 
@@ -3202 +3200 @@
     {
         pCfgReq->Backend.cFramesPeriod = PDMAudioPropsMilliToFrames(&pCfgReq->Props, 150 /*ms*/);
-        RTStrPrintf(szWhat, sizeof(szWhat), "default");
+        pszWhat = "default";
     }
 
     LogRel2(("Audio: Using %s period size %RU64 ms / %RU32 frames for stream '%s'\n",
-             szWhat, PDMAudioPropsFramesToMilli(&pCfgReq->Props, pCfgReq->Backend.cFramesPeriod),
+             pszWhat, PDMAudioPropsFramesToMilli(&pCfgReq->Props, pCfgReq->Backend.cFramesPeriod),
              pCfgReq->Backend.cFramesPeriod, pStream->szName));
 
@@ -3212 +3210 @@
      * Buffer size
      */
+    pszWhat = "";
     if (pDrvCfg->uBufferSizeMs)
     {
         pCfgReq->Backend.cFramesBufferSize = PDMAudioPropsMilliToFrames(&pCfgReq->Props, pDrvCfg->uBufferSizeMs);
-        RTStrPrintf(szWhat, sizeof(szWhat), "custom");
+        pszWhat = "custom";
     }
 
@@ -3221 +3220 @@
     {
         pCfgReq->Backend.cFramesBufferSize = PDMAudioPropsMilliToFrames(&pCfgReq->Props, 300 /*ms*/);
-        RTStrPrintf(szWhat, sizeof(szWhat), "default");
+        pszWhat = "default";
     }
 
     LogRel2(("Audio: Using %s buffer size %RU64 ms / %RU32 frames for stream '%s'\n",
-             szWhat, PDMAudioPropsFramesToMilli(&pCfgReq->Props, pCfgReq->Backend.cFramesBufferSize),
+             pszWhat, PDMAudioPropsFramesToMilli(&pCfgReq->Props, pCfgReq->Backend.cFramesBufferSize),
              pCfgReq->Backend.cFramesBufferSize, pStream->szName));
 
@@ -3231 +3230 @@
      * Pre-buffering size
      */
+    pszWhat = "";
     if (pDrvCfg->uPreBufSizeMs != UINT32_MAX) /* Anything set via global / per-VM extra-data? */
     {
         pCfgReq->Backend.cFramesPreBuffering = PDMAudioPropsMilliToFrames(&pCfgReq->Props, pDrvCfg->uPreBufSizeMs);
-        RTStrPrintf(szWhat, sizeof(szWhat), "custom");
+        pszWhat = "custom";
     }
     else /* No, then either use the default or device-specific settings (if any). */
@@ -3242 +3242 @@
             /* For pre-buffering to finish the buffer at least must be full one time. */
             pCfgReq->Backend.cFramesPreBuffering = pCfgReq->Backend.cFramesBufferSize;
-            RTStrPrintf(szWhat, sizeof(szWhat), "default");
+            pszWhat = "default";
         }
     }
 
     LogRel2(("Audio: Using %s pre-buffering size %RU64 ms / %RU32 frames for stream '%s'\n",
-             szWhat, PDMAudioPropsFramesToMilli(&pCfgReq->Props, pCfgReq->Backend.cFramesPreBuffering),
+             pszWhat, PDMAudioPropsFramesToMilli(&pCfgReq->Props, pCfgReq->Backend.cFramesPreBuffering),
              pCfgReq->Backend.cFramesPreBuffering, pStream->szName));