Changeset 88189 in vbox

Timestamp:

Mar 18, 2021 11:07:36 AM (4 years ago)

Author:

vboxsync

Message:

Some small Solaris-specific build warning fixes:

Additions/solaris/DRM: Remove unused global variable 'g_pDip' from vboxvideo_drm.c.

Additions/solaris/SharedFolders: Add additional #ifdef/#endif around sffs_print() to silence warning: 'sffs_print' defined but not used

IPRT/coredump-solaris: Remove unnecessary and incorrect tag from the ELFWRITENOTE structure declaration which the compiler flags as 'declaration of 'ELFWRITENOTE' shadows a previous local'.

IPRT/thread-posix.cpp: Only call 'Assert((uintptr_t)Self != NIL_RTNATIVETHREAD)' on non-Solaris platforms since the size of pthread_t is implementation-dependent and on Solaris sizeof(pthread_t) = 4 whereas on Linux/MacOS/FreeBSD it is 8. The compiler thus flags this on Solaris as 'comparison is always true due to limited range of data type'.

Location:

trunk/src/VBox

Files:

• Additions/solaris/DRM/vboxvideo_drm.c (modified) (1 diff)
• Additions/solaris/SharedFolders/vboxfs_vfs.c (modified) (2 diffs)
• Runtime/r3/posix/thread-posix.cpp (modified) (1 diff)
• Runtime/r3/solaris/coredumper-solaris.cpp (modified) (1 diff)

trunk/src/VBox/Additions/solaris/DRM/vboxvideo_drm.c

@@ -127 +127 @@
 *   Global Variables                                                                                                             *
 *********************************************************************************************************************************/
-/** Device handle (we support only one instance). */
-static dev_info_t *g_pDip;
-
 /** Soft state. */
 static void *g_pVBoxVideoSolarisState;

trunk/src/VBox/Additions/solaris/SharedFolders/vboxfs_vfs.c

@@ -241 +241 @@
 }
 
+#ifdef DEBUG_ramshankar
 static void
 sffs_print(sffs_data_t *sffs)
@@ -257 +258 @@
         cmn_err(CE_NOTE, "    sfp_mount_t *sf_handle = 0x%p\n", sffs->sf_handle);
 }
+#endif
 
 static int

trunk/src/VBox/Runtime/r3/posix/thread-posix.cpp

@@ -351 +351 @@
     PRTTHREADINT  pThread = (PRTTHREADINT)pvArgs;
     pthread_t     Self    = pthread_self();
+#if !defined(RT_OS_SOLARIS) /* On Solaris sizeof(pthread_t) = 4 and sizeof(NIL_RTNATIVETHREAD) = 8 */
     Assert((uintptr_t)Self != NIL_RTNATIVETHREAD);
+#endif
     Assert(Self == (pthread_t)(RTNATIVETHREAD)Self);
 

trunk/src/VBox/Runtime/r3/solaris/coredumper-solaris.cpp

@@ -1503 +1503 @@
 #ifdef RT_OS_SOLARIS
     typedef int (*PFNELFWRITENOTEHDR)(PRTSOLCORE pSolCore, uint_t, const void *pcv, size_t cb);
-    typedef struct ELFWRITENOTE
+    typedef struct
     {
         const char        *pszType;