Changeset 88194 in vbox for trunk

Timestamp:

Mar 18, 2021 2:24:00 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

143352

Message:

DevHDA: Removed HDASTATER3::cStreamsActive as nobody actually uses it. bugref:9890

Location:

trunk/src/VBox/Devices/Audio

Files:

• DevHDA.cpp (modified) (5 diffs)
• DevHDA.h (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -1402 +1402 @@
             hdaR3StreamEnable(pStreamShared, pStreamR3, false /* fEnable */);
             ASMAtomicWriteBool(&pStreamShared->State.fRunning, false);
-            if (pThisCC->cStreamsActive > 0)
-                pThisCC->cStreamsActive++;
         }
 
@@ -1485 +1483 @@
                 if (fRun)
                 {
-                    /* Keep track of running streams. */
-                    pThisCC->cStreamsActive++;
-
                     /** @todo move this into a HDAStream.cpp function. */
                     uint64_t tsNow;
@@ -1517 +1512 @@
                 }
                 else
-                {
-                    /* Keep track of running streams. */
-                    Assert(pThisCC->cStreamsActive);
-                    if (pThisCC->cStreamsActive)
-                        pThisCC->cStreamsActive--;
-
                     hdaR3StreamMarkStopped(pStreamShared);
-                }
             }
 
@@ -2870 +2858 @@
     LogFlowFuncEnter();
 
-    pThisCC->cStreamsActive = 0;
-
     HDA_REG(pThis, GCAP)     = HDA_MAKE_GCAP(HDA_MAX_SDO, HDA_MAX_SDI, 0, 0, 1); /* see 6.2.1 */
     HDA_REG(pThis, VMIN)     = 0x00;                                             /* see 6.2.2 */
@@ -3652 +3638 @@
 
             hdaR3StreamMarkStarted(pDevIns, pThis, pStreamShared, tsNow);
-
-            /* Also keep track of the currently active streams. */
-            pThisCC->cStreamsActive++;
         }
     }

trunk/src/VBox/Devices/Audio/DevHDA.h

@@ -231 +231 @@
     /** Mapping table between stream tags and stream states. */
     HDATAG                  aTags[HDA_MAX_TAGS];
-    /** Number of active (running) SDn streams.
-     * @todo pointless, not used for anything at all.  */
-    uint8_t                 cStreamsActive;
-    uint8_t                 abPadding0[7];
     /** R3 Pointer to the device instance. */
     PPDMDEVINSR3            pDevIns;