Changeset 88286 in vbox for trunk/src/VBox/Devices

Timestamp:

Mar 25, 2021 10:33:46 AM (4 years ago)

Author:

vboxsync

Message:

Audio: StreamPlay cleanups in the Debug and Null drivers. bugref:9890

Location:

trunk/src/VBox/Devices/Audio

Files:

• DrvHostAudioDebug.cpp (modified) (1 diff)
• DrvHostAudioNull.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DrvHostAudioDebug.cpp

@@ -217 +217 @@
 
     int rc = AudioHlpFileWrite(pStreamDbg->pFile, pvBuf, cbBuf, 0 /* fFlags */);
-    if (RT_FAILURE(rc))
-    {
+    if (RT_SUCCESS(rc))
+        *pcbWritten = cbBuf;
+    else
         LogRel(("DebugAudio: Writing output failed with %Rrc\n", rc));
-        return rc;
-    }
-
-    *pcbWritten = cbBuf;
-    return VINF_SUCCESS;
+    return rc;
 }
 

trunk/src/VBox/Devices/Audio/DrvHostAudioNull.cpp

@@ -138 +138 @@
  */
 static DECLCALLBACK(int) drvHostNullAudioHA_StreamPlay(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream,
-                                                       const void *pvBuf, uint32_t uBufSize, uint32_t *puWritten)
-{
-    AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
-    AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
-    AssertPtrReturn(pvBuf,      VERR_INVALID_POINTER);
-    AssertReturn(uBufSize,         VERR_INVALID_PARAMETER);
-
+                                                       const void *pvBuf, uint32_t cbBuf, uint32_t *pcbWritten)
+{
     RT_NOREF(pInterface, pStream, pvBuf);
 
-    /* Note: No copying of samples needed here, as this a NULL backend. */
-
-    if (puWritten)
-        *puWritten = uBufSize; /* Return all bytes as written. */
-
+    /* The bitbucket never overflows. */
+    *pcbWritten = cbBuf;
     return VINF_SUCCESS;
 }