VirtualBox

Changeset 88380 in vbox


Ignore:
Timestamp:
Apr 7, 2021 8:04:04 AM (4 years ago)
Author:
vboxsync
Message:

Audio: Removed the unused pfnStreamIterate method from PDMIHOSTAUDIO. bugref:9890

Location:
trunk
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/include/VBox/vmm/pdmaudioifs.h

    r88379 r88380  
    13381338
    13391339    /**
    1340      * Gives the host backend the chance to do some (necessary) iteration work.
    1341      *
    1342      * @returns VBox status code.
    1343      * @param   pInterface          Pointer to the interface structure containing the called function pointer.
    1344      * @param   pStream             Pointer to audio stream.
    1345      */
    1346     DECLR3CALLBACKMEMBER(int, pfnStreamIterate, (PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream));
    1347 
    1348     /**
    13491340     * Plays (writes to) an audio (output) stream.
    13501341     *

  • trunk/src/VBox/Devices/Audio/DrvAudio.cpp

    r88378 r88380  
    13221322    bool fTryClosePending = false;
    13231323
    1324     int rc;
     1324    int rc = VINF_SUCCESS;
    13251325
    13261326    do
    13271327    {
    1328         rc = pThis->pHostDrvAudio->pfnStreamIterate(pThis->pHostDrvAudio, pStreamEx->pvBackend);
    1329         if (RT_FAILURE(rc))
    1330             break;
    1331 
    13321328        if (pStreamEx->Core.enmDir == PDMAUDIODIR_OUT)
    13331329        {
    … …  
    20642060    AssertPtrNullReturn(pHostDrvAudio->pfnStreamGetPending, VERR_INVALID_POINTER);
    20652061    AssertPtrReturn(pHostDrvAudio->pfnStreamGetStatus, VERR_INVALID_POINTER);
    2066     AssertPtrReturn(pHostDrvAudio->pfnStreamIterate, VERR_INVALID_POINTER);
    20672062    AssertPtrReturn(pHostDrvAudio->pfnStreamPlay, VERR_INVALID_POINTER);
    20682063    AssertPtrReturn(pHostDrvAudio->pfnStreamCapture, VERR_INVALID_POINTER);

  • trunk/src/VBox/Devices/Audio/DrvHostAudioAlsa.cpp

    r88378 r88380  
    14441444
    14451445/**
    1446  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    1447  */
    1448 static DECLCALLBACK(int) drvHostAlsaAudioHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    1449 {
    1450     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
    1451     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
    1452 
    1453     LogFlowFuncEnter();
    1454 
    1455     /* Nothing to do here for ALSA. */
    1456     return VINF_SUCCESS;
    1457 }
    1458 
    1459 
    1460 /**
    14611446 * @interface_method_impl{PDMIBASE,pfnQueryInterface}
    14621447 */
    … …  
    15011486    pThis->IHostAudio.pfnStreamGetWritable  = drvHostAlsaAudioHA_StreamGetWritable;
    15021487    pThis->IHostAudio.pfnStreamGetStatus    = drvHostAlsaAudioHA_StreamGetStatus;
    1503     pThis->IHostAudio.pfnStreamIterate      = drvHostAlsaAudioHA_StreamIterate;
    15041488    pThis->IHostAudio.pfnStreamPlay         = drvHostAlsaAudioHA_StreamPlay;
    15051489    pThis->IHostAudio.pfnStreamCapture      = drvHostAlsaAudioHA_StreamCapture;

  • trunk/src/VBox/Devices/Audio/DrvHostAudioCoreAudio.cpp

    r88378 r88380  
    24302430
    24312431/**
    2432  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    2433  */
    2434 static DECLCALLBACK(int) drvHostCoreAudioHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    2435 {
    2436     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
    2437     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
    2438 
    2439     RT_NOREF(pInterface, pStream);
    2440 
    2441     /* Nothing to do here for Core Audio. */
    2442     return VINF_SUCCESS;
    2443 }
    2444 
    2445 
    2446 /**
    24472432 * @interface_method_impl{PDMIHOSTAUDIO,pfnInit}
    24482433 */
    … …  
    25602545    pThis->IHostAudio.pfnStreamGetWritable  = drvHostCoreAudioHA_StreamGetWritable;
    25612546    pThis->IHostAudio.pfnStreamGetStatus    = drvHostCoreAudioHA_StreamGetStatus;
    2562     pThis->IHostAudio.pfnStreamIterate      = drvHostCoreAudioHA_StreamIterate;
    25632547    pThis->IHostAudio.pfnStreamPlay         = drvHostCoreAudioHA_StreamPlay;
    25642548    pThis->IHostAudio.pfnStreamCapture      = drvHostCoreAudioHA_StreamCapture;

  • trunk/src/VBox/Devices/Audio/DrvHostAudioDSound.cpp

    r88378 r88380  
    26032603}
    26042604
    2605 /**
    2606  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    2607  */
    2608 static DECLCALLBACK(int) drvHostDSoundHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    2609 {
    2610     RT_NOREF(pInterface, pStream);
    2611     return VINF_SUCCESS;
    2612 }
    2613 
    26142605
    26152606/*********************************************************************************************************************************
    … …  
    27032694    pThis->IHostAudio.pfnStreamGetWritable  = drvHostDSoundHA_StreamGetWritable;
    27042695    pThis->IHostAudio.pfnStreamGetStatus    = drvHostDSoundHA_StreamGetStatus;
    2705     pThis->IHostAudio.pfnStreamIterate      = drvHostDSoundHA_StreamIterate;
    27062696    pThis->IHostAudio.pfnStreamPlay         = drvHostDSoundHA_StreamPlay;
    27072697    pThis->IHostAudio.pfnStreamCapture      = drvHostDSoundHA_StreamCapture;

  • trunk/src/VBox/Devices/Audio/DrvHostAudioDebug.cpp

    r88378 r88380  
    363363
    364364    return PDMAUDIOSTREAMSTS_FLAGS_INITIALIZED | PDMAUDIOSTREAMSTS_FLAGS_ENABLED;
    365 }
    366 
    367 
    368 /**
    369  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    370  */
    371 static DECLCALLBACK(int) drvHostDebugAudioHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    372 {
    373     RT_NOREF(pInterface, pStream);
    374     return VINF_SUCCESS;
    375365}
    376366
    … …  
    419409    pThis->IHostAudio.pfnStreamGetWritable  = drvHostDebugAudioHA_StreamGetWritable;
    420410    pThis->IHostAudio.pfnStreamGetStatus    = drvHostDebugAudioHA_StreamGetStatus;
    421     pThis->IHostAudio.pfnStreamIterate      = drvHostDebugAudioHA_StreamIterate;
    422411    pThis->IHostAudio.pfnStreamPlay         = drvHostDebugAudioHA_StreamPlay;
    423412    pThis->IHostAudio.pfnStreamCapture      = drvHostDebugAudioHA_StreamCapture;

  • trunk/src/VBox/Devices/Audio/DrvHostAudioNull.cpp

    r88378 r88380  
    298298    RT_NOREF(pInterface, pStream);
    299299    return PDMAUDIOSTREAMSTS_FLAGS_INITIALIZED | PDMAUDIOSTREAMSTS_FLAGS_ENABLED;
    300 }
    301 
    302 
    303 /**
    304  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    305  */
    306 static DECLCALLBACK(int) drvHostNullAudioHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    307 {
    308     RT_NOREF(pInterface, pStream);
    309     return VINF_SUCCESS;
    310300}
    311301
    … …  
    357347    pThis->IHostAudio.pfnStreamGetWritable  = drvHostNullAudioHA_StreamGetWritable;
    358348    pThis->IHostAudio.pfnStreamGetStatus    = drvHostNullAudioHA_StreamGetStatus;
    359     pThis->IHostAudio.pfnStreamIterate      = drvHostNullAudioHA_StreamIterate;
    360349    pThis->IHostAudio.pfnStreamPlay         = drvHostNullAudioHA_StreamPlay;
    361350    pThis->IHostAudio.pfnStreamCapture      = drvHostNullAudioHA_StreamCapture;

  • trunk/src/VBox/Devices/Audio/DrvHostAudioOss.cpp

    r88378 r88380  
    584584    RT_NOREF(pInterface, pStream);
    585585    return PDMAUDIOSTREAMSTS_FLAGS_INITIALIZED | PDMAUDIOSTREAMSTS_FLAGS_ENABLED;
    586 }
    587 
    588 
    589 /**
    590  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    591  */
    592 static DECLCALLBACK(int) drvHostOssAudioHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    593 {
    594     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
    595     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
    596 
    597     LogFlowFuncEnter();
    598 
    599     /* Nothing to do here for OSS. */
    600     return VINF_SUCCESS;
    601586}
    602587
    … …  
    755740    pThis->IHostAudio.pfnStreamGetWritable  = drvHostOssAudioHA_StreamGetWritable;
    756741    pThis->IHostAudio.pfnStreamGetStatus    = drvHostOssAudioHA_StreamGetStatus;
    757     pThis->IHostAudio.pfnStreamIterate      = drvHostOssAudioHA_StreamIterate;
    758742    pThis->IHostAudio.pfnStreamPlay         = drvHostOssAudioHA_StreamPlay;
    759743    pThis->IHostAudio.pfnStreamCapture      = drvHostOssAudioHA_StreamCapture;

  • trunk/src/VBox/Devices/Audio/DrvHostAudioPulseAudio.cpp

    r88378 r88380  
    16281628
    16291629/**
    1630  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    1631  */
    1632 static DECLCALLBACK(int) drvHostPulseAudioHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    1633 {
    1634     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
    1635     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
    1636 
    1637     LogFlowFuncEnter();
    1638 
    1639     /* Nothing to do here for PulseAudio. */
    1640     return VINF_SUCCESS;
    1641 }
    1642 
    1643 
    1644 /**
    16451630 * @interface_method_impl{PDMIBASE,pfnQueryInterface}
    16461631 */
    … …  
    16991684    pThis->IHostAudio.pfnStreamGetWritable  = drvHostPulseAudioHA_StreamGetWritable;
    17001685    pThis->IHostAudio.pfnStreamGetStatus    = drvHostPulseAudioHA_StreamGetStatus;
    1701     pThis->IHostAudio.pfnStreamIterate      = drvHostPulseAudioHA_StreamIterate;
    17021686    pThis->IHostAudio.pfnStreamPlay         = drvHostPulseAudioHA_StreamPlay;
    17031687    pThis->IHostAudio.pfnStreamCapture      = drvHostPulseAudioHA_StreamCapture;

  • trunk/src/VBox/Devices/Audio/DrvHostAudioValidationKit.cpp

    r88378 r88380  
    371371    return PDMAUDIOSTREAMSTS_FLAGS_INITIALIZED | PDMAUDIOSTREAMSTS_FLAGS_ENABLED;
    372372}
    373 
    374 static DECLCALLBACK(int) drvHostValKitAudioHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    375 {
    376     RT_NOREF(pInterface, pStream);
    377     return VINF_SUCCESS;
    378 }
    379 
    380373
    381374/**
    … …  
    422415    pThis->IHostAudio.pfnStreamGetWritable  = drvHostValKitAudioHA_StreamGetWritable;
    423416    pThis->IHostAudio.pfnStreamGetStatus    = drvHostValKitAudioHA_StreamGetStatus;
    424     pThis->IHostAudio.pfnStreamIterate      = drvHostValKitAudioHA_StreamIterate;
    425417    pThis->IHostAudio.pfnStreamPlay         = drvHostValKitAudioHA_StreamPlay;
    426418    pThis->IHostAudio.pfnStreamCapture      = drvHostValKitAudioHA_StreamCapture;

  • trunk/src/VBox/Main/src-client/DrvAudioRec.cpp

    r88378 r88380  
    10241024
    10251025/**
    1026  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    1027  */
    1028 static DECLCALLBACK(int) drvAudioVideoRecHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    1029 {
    1030     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
    1031     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
    1032 
    1033     LogFlowFuncEnter();
    1034 
    1035     /* Nothing to do here for video recording. */
    1036     return VINF_SUCCESS;
    1037 }
    1038 
    1039 
    1040 /**
    10411026 * @interface_method_impl{PDMIBASE,pfnQueryInterface}
    10421027 */
    … …  
    11531138    pThis->IHostAudio.pfnStreamGetWritable  = drvAudioVideoRecHA_StreamGetWritable;
    11541139    pThis->IHostAudio.pfnStreamGetStatus    = drvAudioVideoRecHA_StreamGetStatus;
    1155     pThis->IHostAudio.pfnStreamIterate      = drvAudioVideoRecHA_StreamIterate;
    11561140    pThis->IHostAudio.pfnStreamPlay         = drvAudioVideoRecHA_StreamPlay;
    11571141    pThis->IHostAudio.pfnStreamCapture      = drvAudioVideoRecHA_StreamCapture;

  • trunk/src/VBox/Main/src-client/DrvAudioVRDE.cpp

    r88362 r88380  
    525525
    526526    return fStrmStatus;
    527 }
    528 
    529 
    530 /**
    531  * @interface_method_impl{PDMIHOSTAUDIO,pfnStreamIterate}
    532  */
    533 static DECLCALLBACK(int) drvAudioVrdeHA_StreamIterate(PPDMIHOSTAUDIO pInterface, PPDMAUDIOBACKENDSTREAM pStream)
    534 {
    535     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
    536     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
    537 
    538     /* Nothing to do here for VRDE. */
    539     return VINF_SUCCESS;
    540527}
    541528
    … …  
    728715    pThis->IHostAudio.pfnStreamGetPending  = NULL;
    729716    pThis->IHostAudio.pfnStreamGetStatus   = drvAudioVrdeHA_StreamGetStatus;
    730     pThis->IHostAudio.pfnStreamIterate     = drvAudioVrdeHA_StreamIterate;
    731717    pThis->IHostAudio.pfnStreamPlay        = drvAudioVrdeHA_StreamPlay;
    732718    pThis->IHostAudio.pfnStreamCapture     = drvAudioVrdeHA_StreamCapture;
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette