Changeset 88429 in vbox

Timestamp:

Apr 9, 2021 11:12:13 AM (4 years ago)

Author:

vboxsync

Message:

DrvHostAudioAlsa: Some logging changes. A couple of @todos. bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioAlsa.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioAlsa.cpp

@@ -91 +91 @@
     /** Size (in bytes) of allocated scratch buffer. */
     size_t              cbBuf;
+    /** Internal stream offset (for debugging). */
+    uint64_t            offInternal;
 } ALSAAUDIOSTREAM, *PALSAAUDIOSTREAM;
 
@@ -723 +725 @@
     AssertReturn(cbBuf, VERR_INVALID_PARAMETER);
     AssertPtrReturn(pcbWritten, VERR_INVALID_POINTER);
-    Log4Func(("pvBuf=%p uBufSize=%#x (%u) state=%s - %s\n", pvBuf, cbBuf, cbBuf,
+    Log4Func(("@%#RX64: pvBuf=%p cbBuf=%#x (%u) state=%s - %s\n", pStreamALSA->offInternal, pvBuf, cbBuf, cbBuf,
               snd_pcm_state_name(snd_pcm_state(pStreamALSA->phPCM)), pStreamALSA->pCfg->szName));
 
@@ -761 +763 @@
                               cbToWrite, cFramesWritten, cFramesAvail));
                     *pcbWritten = PDMAudioPropsFramesToBytes(pProps, cFramesWritten);
+                    pStreamALSA->offInternal += *pcbWritten;
                     return VINF_SUCCESS;
                 }
@@ -800 +803 @@
                                   cbToWrite, cFramesWritten, cFramesAvail));
                         *pcbWritten = PDMAudioPropsFramesToBytes(pProps, cFramesWritten);
+                        pStreamALSA->offInternal += *pcbWritten;
                         return VINF_SUCCESS;
                     }
@@ -1099 +1103 @@
         case PDMAUDIOSTREAMCMD_PAUSE:
         {
+            /** @todo shouldn't this try snd_pcm_pause first? */
             err = snd_pcm_drop(pStreamALSA->phPCM);
             if (err < 0)
@@ -1116 +1121 @@
                 || streamState == SND_PCM_STATE_RUNNING)
             {
+                /** @todo r=bird: You want EMT to block here for potentially 200-300ms worth
+                 *        of buffer to be drained?  That's a certifiably bad idea.  */
                 err = snd_pcm_nonblock(pStreamALSA->phPCM, 0);
                 if (err < 0)