VBox

Timestamp:

Apr 10, 2021 12:19:06 AM (4 years ago)

Author:

vboxsync

Message:

Audio: Cleaned up the alsa backend. Removed unused+bogus PDMAUDIOSTREAMCMD_DROP command and mixer duplicate. bugref:9890

Location:

trunk/include/VBox/vmm

Files:

trunk/include/VBox/vmm/pdmaudioifs.h

-              r88433
+              r88452
     /** Invalid zero value as per usual (guards against using unintialized values). */
     PDMAUDIOSTREAMCMD_INVALID = 0,
-    /** Unknown command, do not use.
-     * @todo r=bird: WTF is this supposed to be?  Is DrvAudio or a device
-     *       supposed to issue an unknown command to someone?  For conversion
-     *       mismatches (e.g. mixer), you use the INVALID value. */
-    PDMAUDIOSTREAMCMD_UNKNOWN,
     /** Enables the stream. */
     PDMAUDIOSTREAMCMD_ENABLE,
 …
     PDMAUDIOSTREAMCMD_RESUME,
     /** Drain the stream, that is, play what's in the buffer and then stop.
-     * The effect on input streams amounts to a stop.
+     *
      * A separate DISABLE command will be issued to disable the stream.
 …
      *       state.  (EMT cannot wait hundreds of milliseconds of
      *       buffer to finish draining.)
+     * @note Does not apply to input streams. Backends should refuse such requests.
      * @note No supported by all backends. */
     PDMAUDIOSTREAMCMD_DRAIN,
-    /** Tells the stream to drop all (buffered) audio data immediately.
-     *  No supported by all backends. */
-    PDMAUDIOSTREAMCMD_DROP,
     /** End of valid values. */
     PDMAUDIOSTREAMCMD_END,

-              r88300
+              r88452
+    {
         case PDMAUDIOSTREAMCMD_INVALID: return "Invalid";
-        case PDMAUDIOSTREAMCMD_UNKNOWN: return "Unknown";
         case PDMAUDIOSTREAMCMD_ENABLE:  return "Enable";
         case PDMAUDIOSTREAMCMD_DISABLE: return "Disable";
 …
         case PDMAUDIOSTREAMCMD_RESUME:  return "Resume";
         case PDMAUDIOSTREAMCMD_DRAIN:   return "Drain";
-        case PDMAUDIOSTREAMCMD_DROP:    return "Drop";
         case PDMAUDIOSTREAMCMD_END:
         case PDMAUDIOSTREAMCMD_32BIT_HACK:

Note: See TracChangeset for help on using the changeset viewer.