Changeset 88472 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Apr 12, 2021 3:12:45 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

143727

Message:

FE/Qt: bugref:9871: Network Manager: Move selection to somewhere else while removing item of any kind; Else item being removed can receive item change signal and cause crash.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/networkmanager/UINetworkManager.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/networkmanager/UINetworkManager.cpp

@@ -517 +517 @@
                 else
                 {
+                    /* Move selection to somewhere else: */
+                    if (m_pTreeWidgetHostNetwork->itemBelow(pItem))
+                        m_pTreeWidgetHostNetwork->setCurrentItem(m_pTreeWidgetHostNetwork->itemBelow(pItem));
+                    else if (m_pTreeWidgetHostNetwork->itemAbove(pItem))
+                        m_pTreeWidgetHostNetwork->setCurrentItem(m_pTreeWidgetHostNetwork->itemAbove(pItem));
+                    else
+                        m_pTreeWidgetHostNetwork->setCurrentItem(0);
+
                     /* Remove interface from the tree: */
                     delete pItem;
@@ -650 +658 @@
         else
         {
+            /* Move selection to somewhere else: */
+            if (m_pTreeWidgetNATNetwork->itemBelow(pItem))
+                m_pTreeWidgetNATNetwork->setCurrentItem(m_pTreeWidgetNATNetwork->itemBelow(pItem));
+            else if (m_pTreeWidgetNATNetwork->itemAbove(pItem))
+                m_pTreeWidgetNATNetwork->setCurrentItem(m_pTreeWidgetNATNetwork->itemAbove(pItem));
+            else
+                m_pTreeWidgetNATNetwork->setCurrentItem(0);
+
             /* Remove interface from the tree: */
             delete pItem;